Re: [PATCH] bpf/core.c - silence warning messages

2019-06-12 Thread Daniel Borkmann
On 06/07/2019 04:39 AM, Valdis Klētnieks wrote: > Compiling kernel/bpf/core.c with W=1 causes a flood of warnings: > > kernel/bpf/core.c:1198:65: warning: initialized field overwritten > [-Woverride-init] > 1198 | #define BPF_INSN_3_TBL(x, y, z) [BPF_##x | BPF_##y | BPF_##z] = true > |

Re: [PATCH] bpf/core.c - silence warning messages

2019-06-10 Thread Andrii Nakryiko
On Thu, Jun 6, 2019 at 8:08 PM Valdis Klētnieks wrote: > > Compiling kernel/bpf/core.c with W=1 causes a flood of warnings: > > kernel/bpf/core.c:1198:65: warning: initialized field overwritten > [-Woverride-init] > 1198 | #define BPF_INSN_3_TBL(x, y, z) [BPF_##x | BPF_##y | BPF_##z] = true >

[PATCH] bpf/core.c - silence warning messages

2019-06-06 Thread Valdis Klētnieks
Compiling kernel/bpf/core.c with W=1 causes a flood of warnings: kernel/bpf/core.c:1198:65: warning: initialized field overwritten [-Woverride-init] 1198 | #define BPF_INSN_3_TBL(x, y, z) [BPF_##x | BPF_##y | BPF_##z] = true |

Re: [PATCH] bpf/core.c - silence warning messages

2019-01-28 Thread Song Liu
On Mon, Jan 28, 2019 at 3:35 PM wrote: > > On Mon, 28 Jan 2019 09:18:45 -0800, Song Liu said: > > On Sun, Jan 27, 2019 at 8:43 PM wrote: > > > > The attached patch silences the warnings, because we *know* we're > > > overwriting > > > the default initializer. That leaves bpf/core.c with only 6 o

Re: [PATCH] bpf/core.c - silence warning messages

2019-01-28 Thread Daniel Borkmann
On 01/29/2019 12:48 AM, valdis.kletni...@vt.edu wrote: > On Tue, 29 Jan 2019 00:22:26 +0100, Daniel Borkmann said: >> I think moving in separate file would be overkill, imho. However, lets get >> the kdoc and prototype warning fixed. > > I have a bunch of spare time at the moment, so the kdoc and

Re: [PATCH] bpf/core.c - silence warning messages

2019-01-28 Thread valdis . kletnieks
On Tue, 29 Jan 2019 00:22:26 +0100, Daniel Borkmann said: > I think moving in separate file would be overkill, imho. However, lets get > the kdoc and prototype warning fixed. I have a bunch of spare time at the moment, so the kdoc and prototype warnings are on my to-do list.

Re: [PATCH] bpf/core.c - silence warning messages

2019-01-28 Thread valdis . kletnieks
On Mon, 28 Jan 2019 09:18:45 -0800, Song Liu said: > On Sun, Jan 27, 2019 at 8:43 PM wrote: > > The attached patch silences the warnings, because we *know* we're > > overwriting > > the default initializer. That leaves bpf/core.c with only 6 other warnings, > > which become more visible in compa

Re: [PATCH] bpf/core.c - silence warning messages

2019-01-28 Thread Daniel Borkmann
On 01/28/2019 06:18 PM, Song Liu wrote: > On Sun, Jan 27, 2019 at 8:43 PM wrote: >> >> Compiling kernel/bpf/core.c with W=1 causes a flood of warnings: >> >> kernel/bpf/core.c:1198:65: warning: initialized field overwritten >> [-Woverride-init] >> 1198 | #define BPF_INSN_3_TBL(x, y, z) [BPF_##x

Re: [PATCH] bpf/core.c - silence warning messages

2019-01-28 Thread Song Liu
On Sun, Jan 27, 2019 at 8:43 PM wrote: > > Compiling kernel/bpf/core.c with W=1 causes a flood of warnings: > > kernel/bpf/core.c:1198:65: warning: initialized field overwritten > [-Woverride-init] > 1198 | #define BPF_INSN_3_TBL(x, y, z) [BPF_##x | BPF_##y | BPF_##z] = true > |

[PATCH] bpf/core.c - silence warning messages

2019-01-27 Thread valdis . kletnieks
Compiling kernel/bpf/core.c with W=1 causes a flood of warnings: kernel/bpf/core.c:1198:65: warning: initialized field overwritten [-Woverride-init] 1198 | #define BPF_INSN_3_TBL(x, y, z) [BPF_##x | BPF_##y | BPF_##z] = true |