Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-18 Thread Jan Kara
On Fri 15-03-13 10:54:41, Darrick J. Wong wrote: > On Fri, Mar 15, 2013 at 11:01:05AM +0100, Jan Kara wrote: > > On Thu 14-03-13 15:42:43, Darrick J. Wong wrote: > > > On Wed, Mar 13, 2013 at 10:02:16PM +0100, Jan Kara wrote: > > > > On Wed 13-03-13 12:44:29, Darrick J. Wong wrote: > > > > > On Wed

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-15 Thread Darrick J. Wong
On Fri, Mar 15, 2013 at 11:01:05AM +0100, Jan Kara wrote: > On Thu 14-03-13 15:42:43, Darrick J. Wong wrote: > > On Wed, Mar 13, 2013 at 10:02:16PM +0100, Jan Kara wrote: > > > On Wed 13-03-13 12:44:29, Darrick J. Wong wrote: > > > > On Wed, Mar 13, 2013 at 09:50:21AM +0100, Jan Kara wrote: > > > >

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-15 Thread Jan Kara
On Thu 14-03-13 15:42:43, Darrick J. Wong wrote: > On Wed, Mar 13, 2013 at 10:02:16PM +0100, Jan Kara wrote: > > On Wed 13-03-13 12:44:29, Darrick J. Wong wrote: > > > On Wed, Mar 13, 2013 at 09:50:21AM +0100, Jan Kara wrote: > > > > On Tue 12-03-13 18:10:20, Darrick J. Wong wrote: > > > > > On Tue

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-14 Thread Darrick J. Wong
On Thu, Mar 14, 2013 at 03:46:51PM -0700, Andrew Morton wrote: > On Wed, 13 Mar 2013 22:02:16 +0100 Jan Kara wrote: > > > > > ... remembering why we need to get to sb and why ext3 needs this ... So > > > > maybe a better solution would be to have a bio flag meaning that pages > > > > need > > >

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-14 Thread Andrew Morton
On Thu, 14 Mar 2013 15:42:43 -0700 "Darrick J. Wong" wrote: > Subject: [PATCH] mm: Make snapshotting pages for stable writes a per-bio > operation > > Walking a bio's page mappings has proved problematic, so create a new bio flag > to indicate that a bio's data needs to be snapshotted in order

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-14 Thread Andrew Morton
On Wed, 13 Mar 2013 22:02:16 +0100 Jan Kara wrote: > > > ... remembering why we need to get to sb and why ext3 needs this ... So > > > maybe a better solution would be to have a bio flag meaning that pages > > > need > > > bouncing? And we would set it from filesystems that need it - in case of

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-14 Thread Darrick J. Wong
On Wed, Mar 13, 2013 at 10:02:16PM +0100, Jan Kara wrote: > On Wed 13-03-13 12:44:29, Darrick J. Wong wrote: > > On Wed, Mar 13, 2013 at 09:50:21AM +0100, Jan Kara wrote: > > > On Tue 12-03-13 18:10:20, Darrick J. Wong wrote: > > > > On Tue, Mar 12, 2013 at 03:32:21PM -0700, Andrew Morton wrote: >

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-13 Thread Jan Kara
On Wed 13-03-13 12:44:29, Darrick J. Wong wrote: > On Wed, Mar 13, 2013 at 09:50:21AM +0100, Jan Kara wrote: > > On Tue 12-03-13 18:10:20, Darrick J. Wong wrote: > > > On Tue, Mar 12, 2013 at 03:32:21PM -0700, Andrew Morton wrote: > > > > On Fri, 08 Mar 2013 20:37:36 +0800 Shuge wrote: > > > > >

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-13 Thread Darrick J. Wong
On Wed, Mar 13, 2013 at 09:50:21AM +0100, Jan Kara wrote: > On Tue 12-03-13 18:10:20, Darrick J. Wong wrote: > > On Tue, Mar 12, 2013 at 03:32:21PM -0700, Andrew Morton wrote: > > > On Fri, 08 Mar 2013 20:37:36 +0800 Shuge wrote: > > > > > > > The bounce accept slab pages from jbd2, and flush dca

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-13 Thread Russell King - ARM Linux
On Tue, Mar 12, 2013 at 09:11:38PM -0700, Andrew Morton wrote: > Please reread my email. The page at b_frozen_data was allocated with > GFP_NOFS. Hence it should not need bounce treatment (if arm is > anything like x86). > > And yet it *did* receive bounce treatment. Why? If I had to guess, it

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-13 Thread Jan Kara
On Tue 12-03-13 18:10:20, Darrick J. Wong wrote: > On Tue, Mar 12, 2013 at 03:32:21PM -0700, Andrew Morton wrote: > > On Fri, 08 Mar 2013 20:37:36 +0800 Shuge wrote: > > > > > The bounce accept slab pages from jbd2, and flush dcache on them. > > > When enabling VM_DEBUG, it will tigger VM_BUG_ON

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-12 Thread Andrew Morton
On Wed, 13 Mar 2013 11:35:15 +0800 Shuge wrote: > Hi all > >>> The bounce accept slab pages from jbd2, and flush dcache on them. > >>> When enabling VM_DEBUG, it will tigger VM_BUG_ON in page_mapping(). > >>> So, check PageSlab to avoid it in __blk_queue_bounce(). > >>> > >>> Bug URL: http://lkml

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-12 Thread Shuge
Hi all The bounce accept slab pages from jbd2, and flush dcache on them. When enabling VM_DEBUG, it will tigger VM_BUG_ON in page_mapping(). So, check PageSlab to avoid it in __blk_queue_bounce(). Bug URL: http://lkml.org/lkml/2013/3/7/56 ... .. That sure is strange. I didn't see any o

Re: [PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-12 Thread Darrick J. Wong
On Tue, Mar 12, 2013 at 03:32:21PM -0700, Andrew Morton wrote: > On Fri, 08 Mar 2013 20:37:36 +0800 Shuge wrote: > > > The bounce accept slab pages from jbd2, and flush dcache on them. > > When enabling VM_DEBUG, it will tigger VM_BUG_ON in page_mapping(). > > So, check PageSlab to avoid it in __

[PATCH] bounce:fix bug, avoid to flush dcache on slab page from jbd2.

2013-03-08 Thread Shuge
The bounce accept slab pages from jbd2, and flush dcache on them. When enabling VM_DEBUG, it will tigger VM_BUG_ON in page_mapping(). So, check PageSlab to avoid it in __blk_queue_bounce(). Bug URL: http://lkml.org/lkml/2013/3/7/56 Signed-off-by: shuge --- mm/bounce.c |3 ++- 1 file change