Re: [PATCH] bnx2x: fix assignment of signed expression to unsigned variable

2013-03-23 Thread David Miller
From: Kumar Amit Mehta Date: Sat, 23 Mar 2013 11:52:55 -0700 > fix for incorrect assignment of signed expression to unsigned variable. > > Signed-off-by: Kumar Amit Mehta Returning positive error codes is just as broken as what is there currently. These routines should return 0 or 1, the retu

Re: [PATCH] bnx2x: fix assignment of signed expression to unsigned variable

2013-03-23 Thread Dan Carpenter
On Sat, Mar 23, 2013 at 01:45:11PM -0700, Kumar amit mehta wrote: > On Sat, Mar 23, 2013 at 10:56:47PM +0300, Dan Carpenter wrote: > > > > The fix for this is more involved. The function prototype should > > be changed to return an int. The caller should be updated to check > > for errors. > > >

Re: [PATCH] bnx2x: fix assignment of signed expression to unsigned variable

2013-03-23 Thread Kumar amit mehta
On Sat, Mar 23, 2013 at 10:56:47PM +0300, Dan Carpenter wrote: > On Sat, Mar 23, 2013 at 11:52:55AM -0700, Kumar Amit Mehta wrote: > > fix for incorrect assignment of signed expression to unsigned variable. > > > > This fix isn't right. > > > Signed-off-by: Kumar Amit Mehta > > --- > > drivers

Re: [PATCH] bnx2x: fix assignment of signed expression to unsigned variable

2013-03-23 Thread Dan Carpenter
On Sat, Mar 23, 2013 at 11:52:55AM -0700, Kumar Amit Mehta wrote: > fix for incorrect assignment of signed expression to unsigned variable. > This fix isn't right. > Signed-off-by: Kumar Amit Mehta > --- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c | 20 ++-- > 1 file ch

[PATCH] bnx2x: fix assignment of signed expression to unsigned variable

2013-03-23 Thread Kumar Amit Mehta
fix for incorrect assignment of signed expression to unsigned variable. Signed-off-by: Kumar Amit Mehta --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c