Re: [PATCH] bnx2fc: shift wrapping bug in bnx2fc_process_unsol_compl()

2016-11-28 Thread Laurence Oberman
;Christophe JAILLET" > > Sent: Saturday, November 26, 2016 1:36:29 PM > Subject: [PATCH] bnx2fc: shift wrapping bug in bnx2fc_process_unsol_compl() > > BNX2FC_NUM_ERR_BITS is 63. err_warn_bit_map is a u64. So, to make sure that > no shift wrapping will occur, we need need additionna

Re: [PATCH] bnx2fc: shift wrapping bug in bnx2fc_process_unsol_compl()

2016-11-28 Thread Dan Carpenter
On Sat, Nov 26, 2016 at 07:36:29PM +0100, Christophe JAILLET wrote: > BNX2FC_NUM_ERR_BITS is 63. err_warn_bit_map is a u64. So, to make sure that > no shift wrapping will occur, we need need additionnal casting. > > The same test is already done a few lines above and '(u64)1' is already > used the

[PATCH] bnx2fc: shift wrapping bug in bnx2fc_process_unsol_compl()

2016-11-26 Thread Christophe JAILLET
BNX2FC_NUM_ERR_BITS is 63. err_warn_bit_map is a u64. So, to make sure that no shift wrapping will occur, we need need additionnal casting. The same test is already done a few lines above and '(u64)1' is already used there. So just do the same here. Signed-off-by: Christophe JAILLET --- I guess