Re: [PATCH] bluetooth: hci_h5: avoid unused variable warnings

2018-08-14 Thread Arnd Bergmann
On Tue, Aug 14, 2018 at 9:22 AM Hans de Goede wrote: > > Hi Arnd, > > On 14-08-18 00:04, Arnd Bergmann wrote: > > When CONFIG_BT_HCIUART_RTL is disabled, the hci_h5 driver produces a build > > warning because of an incorrect set of #ifdef guards: > > > > drivers/bluetooth/hci_h5.c:920:22: error: '

Re: [PATCH] bluetooth: hci_h5: avoid unused variable warnings

2018-08-14 Thread Hans de Goede
Hi Arnd, On 14-08-18 00:04, Arnd Bergmann wrote: When CONFIG_BT_HCIUART_RTL is disabled, the hci_h5 driver produces a build warning because of an incorrect set of #ifdef guards: drivers/bluetooth/hci_h5.c:920:22: error: 'rtl_vnd' defined but not used [-Werror=unused-variable] Replacing the #i

Re: [PATCH] bluetooth: hci_h5: avoid unused variable warnings

2018-08-14 Thread Marcel Holtmann
Hi Arnd, > When CONFIG_BT_HCIUART_RTL is disabled, the hci_h5 driver produces a build > warning because of an incorrect set of #ifdef guards: > > drivers/bluetooth/hci_h5.c:920:22: error: 'rtl_vnd' defined but not used > [-Werror=unused-variable] > > Replacing the #ifdef with an IS_ENABLED() ch

Re: [PATCH] bluetooth: hci_h5: avoid unused variable warnings

2018-08-13 Thread Kees Cook
On Mon, Aug 13, 2018 at 3:04 PM, Arnd Bergmann wrote: > When CONFIG_BT_HCIUART_RTL is disabled, the hci_h5 driver produces a build > warning because of an incorrect set of #ifdef guards: > > drivers/bluetooth/hci_h5.c:920:22: error: 'rtl_vnd' defined but not used > [-Werror=unused-variable] > > R

[PATCH] bluetooth: hci_h5: avoid unused variable warnings

2018-08-13 Thread Arnd Bergmann
When CONFIG_BT_HCIUART_RTL is disabled, the hci_h5 driver produces a build warning because of an incorrect set of #ifdef guards: drivers/bluetooth/hci_h5.c:920:22: error: 'rtl_vnd' defined but not used [-Werror=unused-variable] Replacing the #ifdef with an IS_ENABLED() check shuts up the error a