Re: [Drbd-dev] [PATCH] block/drbd: Fix a sleep-in-atomic bug in drbd_bcast_event

2017-10-09 Thread Roland Kammerer
On Wed, Oct 04, 2017 at 09:33:18AM +0800, Jia-Ju Bai wrote: > The driver may sleep under a RCU lock, and the function call path is: > drbd_sync_handshake (acquire the RCU lock) > drbd_asb_recover_1p > drbd_khelper > drbd_bcast_event > genlmsg_new(GFP_NOIO) --> may sleep > > To

[PATCH] block/drbd: Fix a sleep-in-atomic bug in drbd_bcast_event

2017-10-03 Thread Jia-Ju Bai
The driver may sleep under a RCU lock, and the function call path is: drbd_sync_handshake (acquire the RCU lock) drbd_asb_recover_1p drbd_khelper drbd_bcast_event genlmsg_new(GFP_NOIO) --> may sleep To fix it, GFP_NOIO is replaced with GFP_ATOMIC. This bug is found by my static