Re: [PATCH] blkdev: Fix blkdev_open to release the bdev on error

2015-12-08 Thread Vegard Nossum
On 8 December 2015 at 11:08, Suzuki K. Poulose wrote: > On 08/12/15 07:58, Al Viro wrote: >> >> On Mon, Dec 07, 2015 at 10:49:05AM -0800, Linus Torvalds wrote: >>> >>> On Mon, Dec 7, 2015 at 10:05 AM, Suzuki K. Poulose >>> wrote: > > > ... > >> Anyway, the fix for 9p bogosity follows; it definite

Re: [PATCH] blkdev: Fix blkdev_open to release the bdev on error

2015-12-08 Thread Suzuki K. Poulose
On 08/12/15 07:58, Al Viro wrote: On Mon, Dec 07, 2015 at 10:49:05AM -0800, Linus Torvalds wrote: On Mon, Dec 7, 2015 at 10:05 AM, Suzuki K. Poulose wrote: ... Anyway, the fix for 9p bogosity follows; it definitely fixes a bug there, and I'm fairly sure that it fixes the bug that had been r

Re: [PATCH] blkdev: Fix blkdev_open to release the bdev on error

2015-12-08 Thread Suzuki K. Poulose
On 08/12/15 07:25, Al Viro wrote: On Mon, Dec 07, 2015 at 06:05:03PM +, Suzuki K. Poulose wrote: blkdev_open() doesn't release the bdev, it attached to a given inode, if blkdev_get() fails (e.g, due to absence of a device). This can cause kernel crashes when the original filesystem tries to

Re: [PATCH] blkdev: Fix blkdev_open to release the bdev on error

2015-12-07 Thread Al Viro
On Mon, Dec 07, 2015 at 10:49:05AM -0800, Linus Torvalds wrote: > On Mon, Dec 7, 2015 at 10:05 AM, Suzuki K. Poulose > wrote: > > blkdev_open() doesn't release the bdev, it attached to a given > > inode, if blkdev_get() fails (e.g, due to absence of a device). > > This can cause kernel crashes whe

Re: [PATCH] blkdev: Fix blkdev_open to release the bdev on error

2015-12-07 Thread Al Viro
On Mon, Dec 07, 2015 at 06:05:03PM +, Suzuki K. Poulose wrote: > blkdev_open() doesn't release the bdev, it attached to a given > inode, if blkdev_get() fails (e.g, due to absence of a device). > This can cause kernel crashes when the original filesystem > tries to flush the data during evict_i

Re: [PATCH] blkdev: Fix blkdev_open to release the bdev on error

2015-12-07 Thread Linus Torvalds
On Mon, Dec 7, 2015 at 10:05 AM, Suzuki K. Poulose wrote: > blkdev_open() doesn't release the bdev, it attached to a given > inode, if blkdev_get() fails (e.g, due to absence of a device). > This can cause kernel crashes when the original filesystem > tries to flush the data during evict_inode. U

[PATCH] blkdev: Fix blkdev_open to release the bdev on error

2015-12-07 Thread Suzuki K. Poulose
blkdev_open() doesn't release the bdev, it attached to a given inode, if blkdev_get() fails (e.g, due to absence of a device). This can cause kernel crashes when the original filesystem tries to flush the data during evict_inode. This can be triggered easily with virtio-9p fs using the following s