Re: [PATCH] blkcg: handle dying request_queue when associating a blkg

2018-12-13 Thread Dennis Zhou
On Wed, Dec 12, 2018 at 03:54:52PM -0800, Bart Van Assche wrote: > On Tue, 2018-12-11 at 23:06 -0500, Dennis Zhou wrote: > > Hi Bart, > > > > On Tue, Dec 11, 2018 at 03:16:13PM -0800, Bart Van Assche wrote: > > > On Tue, 2018-12-11 at 18:03 -0500, Dennis Zhou wrote: > > > > diff --git a/block/blk-

Re: [PATCH] blkcg: handle dying request_queue when associating a blkg

2018-12-12 Thread Jens Axboe
On 12/11/18 4:03 PM, Dennis Zhou wrote: > Between v3 [1] and v4 [2] of the blkg association series, the > association point moved from generic_make_request_checks(), which is > called after the request enters the queue, to bio_set_dev(), which is when > the bio is formed before submit_bio(). When t

Re: [PATCH] blkcg: handle dying request_queue when associating a blkg

2018-12-12 Thread Bart Van Assche
On Tue, 2018-12-11 at 23:06 -0500, Dennis Zhou wrote: > Hi Bart, > > On Tue, Dec 11, 2018 at 03:16:13PM -0800, Bart Van Assche wrote: > > On Tue, 2018-12-11 at 18:03 -0500, Dennis Zhou wrote: > > > diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c > > > index 6bd0619a7d6e..c30661ddc873 100644 >

Re: [PATCH] blkcg: handle dying request_queue when associating a blkg

2018-12-11 Thread Dennis Zhou
Hi Bart, On Tue, Dec 11, 2018 at 03:16:13PM -0800, Bart Van Assche wrote: > On Tue, 2018-12-11 at 18:03 -0500, Dennis Zhou wrote: > > diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c > > index 6bd0619a7d6e..c30661ddc873 100644 > > --- a/block/blk-cgroup.c > > +++ b/block/blk-cgroup.c > > @@ -2

Re: [PATCH] blkcg: handle dying request_queue when associating a blkg

2018-12-11 Thread Bart Van Assche
On Tue, 2018-12-11 at 18:03 -0500, Dennis Zhou wrote: > diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c > index 6bd0619a7d6e..c30661ddc873 100644 > --- a/block/blk-cgroup.c > +++ b/block/blk-cgroup.c > @@ -202,6 +202,12 @@ static struct blkcg_gq *blkg_create(struct blkcg *blkcg, > WARN_O

[PATCH] blkcg: handle dying request_queue when associating a blkg

2018-12-11 Thread Dennis Zhou
Between v3 [1] and v4 [2] of the blkg association series, the association point moved from generic_make_request_checks(), which is called after the request enters the queue, to bio_set_dev(), which is when the bio is formed before submit_bio(). When the request_queue goes away, the blkgs supporting