Re: [PATCH] blk-mq: prevent unmapped hw queue from being scheduled

2014-12-08 Thread Ming Lei
On Tue, Dec 9, 2014 at 12:39 PM, Jens Axboe wrote: > On 12/08/2014 05:41 PM, Ming Lei wrote: > > > Picked up for 3.19, sorry for the delay. I'm curious how this queue gets Thanks! > scheduled, though. My worry here would be that we are masking a bug that > should be fixed separately. That is be

Re: [PATCH] blk-mq: prevent unmapped hw queue from being scheduled

2014-12-08 Thread Jens Axboe
On 12/08/2014 05:41 PM, Ming Lei wrote: On Wed, Dec 3, 2014 at 7:38 PM, Ming Lei wrote: When one hardware queue has no mapped software queues, it shouldn't have been scheduled. Otherwise WARNING or OOPS can triggered. blk_mq_hw_queue_mapped() helper is introduce for fixing the problem. Signed

Re: [PATCH] blk-mq: prevent unmapped hw queue from being scheduled

2014-12-08 Thread Ming Lei
On Wed, Dec 3, 2014 at 7:38 PM, Ming Lei wrote: > When one hardware queue has no mapped software queues, it > shouldn't have been scheduled. Otherwise WARNING or OOPS > can triggered. > > blk_mq_hw_queue_mapped() helper is introduce for fixing > the problem. > > Signed-off-by: Ming Lei > --- > b

[PATCH] blk-mq: prevent unmapped hw queue from being scheduled

2014-12-03 Thread Ming Lei
When one hardware queue has no mapped software queues, it shouldn't have been scheduled. Otherwise WARNING or OOPS can triggered. blk_mq_hw_queue_mapped() helper is introduce for fixing the problem. Signed-off-by: Ming Lei --- block/blk-mq.c |8 ++-- block/blk-mq.h |5 + 2 files