Re: [PATCH] blk-mq: Fix refcounting leak in __blk_mq_register_dev()

2020-09-07 Thread Ming Lei
On Sat, Sep 05, 2020 at 03:52:06PM +0300, Dan Carpenter wrote: > There is a kobject_add() hidden in the call to kobject_add(). > > ret = kobject_add(q->mq_kobj, kobject_get(&dev->kobj), "%s", "mq"); > ^^^ > > It needs to be release o

[PATCH] blk-mq: Fix refcounting leak in __blk_mq_register_dev()

2020-09-05 Thread Dan Carpenter
There is a kobject_add() hidden in the call to kobject_add(). ret = kobject_add(q->mq_kobj, kobject_get(&dev->kobj), "%s", "mq"); ^^^ It needs to be release on the error path. Fixes: 320ae51feed5 ("blk-mq: new multi-queue block IO