Re: [PATCH] binder: reduce mmap_sem write-side lock

2019-02-19 Thread Todd Kjos
On Mon, Feb 18, 2019 at 2:47 AM Minchan Kim wrote: > > On Mon, Feb 18, 2019 at 09:32:08AM +0100, Greg KH wrote: > > On Mon, Feb 18, 2019 at 05:11:45PM +0900, Minchan Kim wrote: > > > binder has used write-side mmap_sem semaphore to release memory > > > mapped at address space of the process. Howev

Re: [PATCH] binder: reduce mmap_sem write-side lock

2019-02-18 Thread Minchan Kim
On Mon, Feb 18, 2019 at 09:32:08AM +0100, Greg KH wrote: > On Mon, Feb 18, 2019 at 05:11:45PM +0900, Minchan Kim wrote: > > binder has used write-side mmap_sem semaphore to release memory > > mapped at address space of the process. However, right lock to > > release pages is down_read, not down_wri

Re: [PATCH] binder: reduce mmap_sem write-side lock

2019-02-18 Thread Greg KH
On Mon, Feb 18, 2019 at 05:11:45PM +0900, Minchan Kim wrote: > binder has used write-side mmap_sem semaphore to release memory > mapped at address space of the process. However, right lock to > release pages is down_read, not down_write because page table lock > already protects the race for parall

[PATCH] binder: reduce mmap_sem write-side lock

2019-02-18 Thread Minchan Kim
binder has used write-side mmap_sem semaphore to release memory mapped at address space of the process. However, right lock to release pages is down_read, not down_write because page table lock already protects the race for parallel freeing. Please do not use mmap_sem write-side lock which is well