Re: [PATCH] bcache: Use #ifdef instead of boolean variable

2020-10-10 Thread Alex Dewar
On Sat, Oct 10, 2020 at 10:05:22AM +0800, Coly Li wrote: > On 2020/10/10 07:00, Rasmus Villemoes wrote: > > On 09/10/2020 20.34, Alex Dewar wrote: > >> The variable async_registration is used to indicate whether or not > >> CONFIG_BCACHE_ASYNC_REGISTRATION is enabled, triggering a (false) > >> warn

Re: [PATCH] bcache: Use #ifdef instead of boolean variable

2020-10-09 Thread Coly Li
On 2020/10/10 07:00, Rasmus Villemoes wrote: > On 09/10/2020 20.34, Alex Dewar wrote: >> The variable async_registration is used to indicate whether or not >> CONFIG_BCACHE_ASYNC_REGISTRATION is enabled, triggering a (false) >> warning in Coverity about unreachable code. However, it seems clearer i

Re: [PATCH] bcache: Use #ifdef instead of boolean variable

2020-10-09 Thread Rasmus Villemoes
On 09/10/2020 20.34, Alex Dewar wrote: > The variable async_registration is used to indicate whether or not > CONFIG_BCACHE_ASYNC_REGISTRATION is enabled, triggering a (false) > warning in Coverity about unreachable code. However, it seems clearer in > this case just to use an #ifdef, so let's do t

Re: [PATCH] bcache: Use #ifdef instead of boolean variable

2020-10-09 Thread kernel test robot
Hi Alex, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20201009] [cannot apply to linus/master v5.9-rc8 v5.9-rc7 v5.9-rc6 v5.9-rc8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [PATCH] bcache: Use #ifdef instead of boolean variable

2020-10-09 Thread kernel test robot
Hi Alex, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20201009] [cannot apply to linus/master v5.9-rc8 v5.9-rc7 v5.9-rc6 v5.9-rc8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

[PATCH] bcache: Use #ifdef instead of boolean variable

2020-10-09 Thread Alex Dewar
The variable async_registration is used to indicate whether or not CONFIG_BCACHE_ASYNC_REGISTRATION is enabled, triggering a (false) warning in Coverity about unreachable code. However, it seems clearer in this case just to use an #ifdef, so let's do that instead. Addresses-Coverity-ID: 1497746: C