Re: [PATCH] balance parenthesis in serial core

2007-06-27 Thread Alan Cox
On Wed, 27 Jun 2007 22:22:00 +0200 Mariusz Kozlowski <[EMAIL PROTECTED]> wrote: > Hello, > > This patch balances the parenthesis imbalance in serial core. > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Ack although the right thing to do is to remove these checks (and I'm doing s

Re: [PATCH] balance parenthesis in serial core

2007-06-27 Thread Andrew Morton
On Wed, 27 Jun 2007 21:42:38 +0100 David Woodhouse <[EMAIL PROTECTED]> wrote: > On Wed, 2007-06-27 at 13:37 -0700, Andrew Morton wrote: > > Thanks. so... why shouldn't we just remove the buggy&&unused > > RELEVANT_CFLAG defines?? > > I was just about to suggest that. I originally intended to us

Re: [PATCH] balance parenthesis in serial core

2007-06-27 Thread David Woodhouse
On Wed, 2007-06-27 at 13:37 -0700, Andrew Morton wrote: > Thanks. so... why shouldn't we just remove the buggy&&unused > RELEVANT_CFLAG defines?? I was just about to suggest that. I originally intended to use them for the obvious purpose, but then realised that we can just rely on the integers i

Re: [PATCH] balance parenthesis in serial core

2007-06-27 Thread Andrew Morton
On Wed, 27 Jun 2007 22:22:00 +0200 Mariusz Kozlowski <[EMAIL PROTECTED]> wrote: > Hello, > > This patch balances the parenthesis imbalance in serial core. > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > drivers/serial/serial_core.c |4 ++-- > 1 file changed, 2 insertions

[PATCH] balance parenthesis in serial core

2007-06-27 Thread Mariusz Kozlowski
Hello, This patch balances the parenthesis imbalance in serial core. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/serial/serial_core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.22-rc6-bo-a/drivers/serial/serial_core.c 2007-06-27 22:05: