Re: [PATCH] backlight dimmer

2007-11-01 Thread jack
Pavel Machek wrote: On Sun 2007-10-28 17:10:53, [EMAIL PROTECTED] wrote: Hello, this patch implements a macbook like backlight dimmer on top of backlight.c. The dimmer is entirely in kernelspace and is suitable for an embedded context in order to avoid the overhead of a daemon controlling t

Re: [PATCH] backlight dimmer

2007-11-01 Thread Pavel Machek
On Sun 2007-10-28 17:10:53, [EMAIL PROTECTED] wrote: > Hello, > this patch implements a macbook like backlight dimmer on > top of backlight.c. > > The dimmer is entirely in kernelspace and is suitable > for an embedded context in order to avoid the overhead > of a daemon controlling the backlig

Re: [PATCH] backlight dimmer

2007-10-28 Thread jack
Arjan van de Ven wrote: On Sun, 28 Oct 2007 22:30:55 +0100 "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: Ok, now checkpatch.pl only complains about a missing signed-off-by. Is this ok for review? hi, when going over your patch.. is there a reason you introduce yet another timeout infrast

Re: [PATCH] backlight dimmer

2007-10-28 Thread Arjan van de Ven
On Sun, 28 Oct 2007 22:30:55 +0100 "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > Ok, > now checkpatch.pl only complains about a missing signed-off-by. > Is this ok for review? hi, when going over your patch.. is there a reason you introduce yet another timeout infrastructure? Is there some

Re: [PATCH] backlight dimmer

2007-10-28 Thread [EMAIL PROTECTED]
Ok, now checkpatch.pl only complains about a missing signed-off-by. Is this ok for review? jacopo --- linux-2.6.23.1/include/linux/backlight.h2007-10-12 18:43:44.0 +0200 +++ b/include/linux/backlight.h 2007-10-28 21:14:21.0 +0100 @@ -11,6 +11,7 @@ #include #include #incl

Re: [PATCH] backlight dimmer

2007-10-28 Thread Samuel Tardieu
> "Jacopo" == jack <[EMAIL PROTECTED]> writes: Jacopo> this patch implements a macbook like backlight dimmer on top Jacopo> of backlight.c. Jacopo, if you want your patch to be reviewed, you should first put it in an acceptable form. You can start by running it through scripts/checkpatch.pl.

[PATCH] backlight dimmer

2007-10-28 Thread jack
Hello, this patch implements a macbook like backlight dimmer on top of backlight.c. The dimmer is entirely in kernelspace and is suitable for an embedded context in order to avoid the overhead of a daemon controlling the backlight. Implementing this functionality in userspace has other advan