Re: [PATCH] autofs4: fix race in unhashed dentry code

2007-04-11 Thread Ian Kent
On Wed, 2007-04-11 at 14:13 -0400, Jeff Mahoney wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Ian Kent wrote: > > On Thu, 2007-04-12 at 02:00 +0800, Ian Kent wrote: > >> On Thu, 2007-04-12 at 01:49 +0800, Ian Kent wrote: > >>> On Wed, 2007-04-11 at 11:05 -0400, Jeff Mahoney wrote: >

Re: [PATCH] autofs4: fix race in unhashed dentry code

2007-04-11 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ian Kent wrote: > On Thu, 2007-04-12 at 02:00 +0800, Ian Kent wrote: >> On Thu, 2007-04-12 at 01:49 +0800, Ian Kent wrote: >>> On Wed, 2007-04-11 at 11:05 -0400, Jeff Mahoney wrote: Commit f50b6f8691cae2e0064c499dd3ef3f31142987f0 introduced a >>>

Re: [PATCH] autofs4: fix race in unhashed dentry code

2007-04-11 Thread Ian Kent
On Thu, 2007-04-12 at 02:00 +0800, Ian Kent wrote: > On Thu, 2007-04-12 at 01:49 +0800, Ian Kent wrote: > > On Wed, 2007-04-11 at 11:05 -0400, Jeff Mahoney wrote: > > > Commit f50b6f8691cae2e0064c499dd3ef3f31142987f0 introduced a > > > race in autofs4 between autofs_lookup_unhashed() and > > > a

Re: [PATCH] autofs4: fix race in unhashed dentry code

2007-04-11 Thread Ian Kent
On Thu, 2007-04-12 at 01:49 +0800, Ian Kent wrote: > On Wed, 2007-04-11 at 11:05 -0400, Jeff Mahoney wrote: > > Commit f50b6f8691cae2e0064c499dd3ef3f31142987f0 introduced a > > race in autofs4 between autofs_lookup_unhashed() and > > autofs_dentry_release(). > > > > autofs_dentry_release() end

Re: [PATCH] autofs4: fix race in unhashed dentry code

2007-04-11 Thread Ian Kent
On Wed, 2007-04-11 at 11:05 -0400, Jeff Mahoney wrote: > Commit f50b6f8691cae2e0064c499dd3ef3f31142987f0 introduced a > race in autofs4 between autofs_lookup_unhashed() and > autofs_dentry_release(). > > autofs_dentry_release() ends up clearing the ->dentry and ->inode > members of autofs_inf

[PATCH] autofs4: fix race in unhashed dentry code

2007-04-11 Thread Jeff Mahoney
Commit f50b6f8691cae2e0064c499dd3ef3f31142987f0 introduced a race in autofs4 between autofs_lookup_unhashed() and autofs_dentry_release(). autofs_dentry_release() ends up clearing the ->dentry and ->inode members of autofs_info before removing it from the rehash list. The list is protected b