Re: [PATCH] autofs4: deadlock during create

2007-08-16 Thread Andrew Morton
On Fri, 17 Aug 2007 11:56:11 +0800 Ian Kent <[EMAIL PROTECTED]> wrote: > On Wed, 2007-08-15 at 14:31 +0800, Ian Kent wrote: > > On Tue, 2007-08-14 at 10:17 -0400, Jeff Moyer wrote: > > > Ian Kent <[EMAIL PROTECTED]> writes: > > > > > > > > After spending quite a bit of time trying to resolve this

Re: [PATCH] autofs4: deadlock during create

2007-08-16 Thread Ian Kent
On Wed, 2007-08-15 at 14:31 +0800, Ian Kent wrote: > On Tue, 2007-08-14 at 10:17 -0400, Jeff Moyer wrote: > > Ian Kent <[EMAIL PROTECTED]> writes: > > > > > > After spending quite a bit of time trying to resolve this on more than > > > one occassion, using rather complex and ulgy approaches, it tur

Re: [autofs] [PATCH] autofs4: deadlock during create

2007-08-14 Thread Ian Kent
On Tue, 2007-08-14 at 10:17 -0400, Jeff Moyer wrote: > Ian Kent <[EMAIL PROTECTED]> writes: > > > > After spending quite a bit of time trying to resolve this on more than > > one occassion, using rather complex and ulgy approaches, it turns out > > that just delaying the hashing of the dentry until

Re: [autofs] [PATCH] autofs4: deadlock during create

2007-08-14 Thread Jeff Moyer
Ian Kent <[EMAIL PROTECTED]> writes: > Hi, > > Due to inconsistent locking in the VFS between calls to lookup and > revalidate deadlock can occur in the automounter. > > The inconsistency is that the directory inode mutex is held for both > lookup and revalidate calls when called via lookup_hash w

[PATCH] autofs4: deadlock during create

2007-08-14 Thread Ian Kent
Hi, Due to inconsistent locking in the VFS between calls to lookup and revalidate deadlock can occur in the automounter. The inconsistency is that the directory inode mutex is held for both lookup and revalidate calls when called via lookup_hash whereas it is held only for lookup during a path wa