Re: [PATCH] autofs: fix error code path in autofs_fill_sb()

2006-11-30 Thread Andrew Morton
On Thu, 30 Nov 2006 13:14:35 +0800 Ian Kent <[EMAIL PROTECTED]> wrote: > > The problem: autofs_fill_super() returns EINVAL to get_sb_nodev(), but > > before > > that, it calls kill_anon_super() to destroy the superblock which won't be > > needed. This is however way too soon to call kill_anon_su

Re: [PATCH] autofs: fix error code path in autofs_fill_sb()

2006-11-30 Thread Jiri Kosina
On Thu, 30 Nov 2006, Ian Kent wrote: > > Signed-off-by: Jiri Kosina <[EMAIL PROTECTED]> > Acked-by: Ian Kent <[EMAIL PROTECTED]> > It looks so obvious now. > Updating the comment above would be a good idea also, see attached. Yes, I agree. Andrew, could you please apply it on top of my fix? Than

Re: [PATCH] autofs: fix error code path in autofs_fill_sb()

2006-11-29 Thread Ian Kent
On Thu, 2006-11-30 at 01:26 +0100, Jiri Kosina wrote: > [PATCH] autofs: fix error code path in autofs_fill_sb() > > When kernel is compiled with old version of autofs (CONFIG_AUTOFS_FS), and > new (observed at least with 5.x.x) automount deamon is started, kernel > co

[PATCH] autofs: fix error code path in autofs_fill_sb()

2006-11-29 Thread Jiri Kosina
[PATCH] autofs: fix error code path in autofs_fill_sb() When kernel is compiled with old version of autofs (CONFIG_AUTOFS_FS), and new (observed at least with 5.x.x) automount deamon is started, kernel correctly reports incompatible version of kernel and userland daemon, but then screws things