Re: [PATCH] audit: vfs: fix audit records error when write to a file

2014-09-17 Thread Richard Guy Briggs
On 14/09/05, 胡剑阳 wrote: > Hi Jeff, Hello gentlemen, > I don't know if we can keep audit_inode() in do_last(). I've tried > this but found > the only way to enable both write() and create() is moving it to > lookup_open(). > I know this is not good, but I think we have no choice. > > The current

Re: [PATCH] audit: vfs: fix audit records error when write to a file

2014-09-05 Thread 胡剑阳
Hi Jeff, I don't know if we can keep audit_inode() in do_last(). I've tried this but found the only way to enable both write() and create() is moving it to lookup_open(). I know this is not good, but I think we have no choice. The current patch really miss the ROFS condition as you said. How abou

Re: [PATCH] audit: vfs: fix audit records error when write to a file

2014-09-05 Thread Jeff Layton
On Fri, 5 Sep 2014 14:55:53 +0800 hujianyang wrote: > commit 33e2208acfc1 > > audit: vfs: fix audit_inode call in O_CREAT case of do_last > > fix a regression in auditing of open(..., O_CREAT) syscalls but > import a new problem which lead the records of write operation > confusion. > > This e

[PATCH] audit: vfs: fix audit records error when write to a file

2014-09-04 Thread hujianyang
commit 33e2208acfc1 audit: vfs: fix audit_inode call in O_CREAT case of do_last fix a regression in auditing of open(..., O_CREAT) syscalls but import a new problem which lead the records of write operation confusion. This error can be reproduced by these steps: touch /etc/test