Re: [PATCH] atm: introduce vcc_pop()

2012-11-28 Thread Krzysztof Mazur
On Wed, Nov 28, 2012 at 04:59:06PM -0500, chas williams - CONTRACTOR wrote: > On Wed, 28 Nov 2012 22:45:34 +0100 > Krzysztof Mazur wrote: > > > On Wed, Nov 28, 2012 at 04:20:01PM -0500, chas williams - CONTRACTOR wrote: > > > i dont like the vcc->pop() implementation and at one point i had the >

Re: [PATCH] atm: introduce vcc_pop()

2012-11-28 Thread chas williams - CONTRACTOR
On Wed, 28 Nov 2012 22:45:34 +0100 Krzysztof Mazur wrote: > On Wed, Nov 28, 2012 at 04:20:01PM -0500, chas williams - CONTRACTOR wrote: > > i dont like the vcc->pop() implementation and at one point i had the > > crazy idea of using skb->destructors to handle it. however, i think it > > would be

[PATCH] atm: introduce vcc_pop()

2012-11-28 Thread Krzysztof Mazur
On Wed, Nov 28, 2012 at 04:20:01PM -0500, chas williams - CONTRACTOR wrote: > On Wed, 28 Nov 2012 21:18:37 +0100 > Krzysztof Mazur wrote: > > > On Tue, Nov 27, 2012 at 07:28:43PM +0100, Krzysztof Mazur wrote: > > > I think that we should add atm_pop() function that does that and fix all > > > dri