Re: [PATCH] ath9k: unlock rcu read when returning early

2016-12-13 Thread Felix Fietkau
On 2016-12-13 14:41, Tobias Klausmann wrote: > On 13.12.2016 11:41, Felix Fietkau wrote: >> On 2016-12-12 19:50, Tobias Klausmann wrote: >>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c >>> b/drivers/net/wireless/ath/ath9k/xmit.c >>> index 52bfbb988611..857d5ae09a1d 100644 >>> --- a/drivers/

Re: [PATCH] ath9k: unlock rcu read when returning early

2016-12-13 Thread Tobias Klausmann
On 13.12.2016 11:41, Felix Fietkau wrote: On 2016-12-12 19:50, Tobias Klausmann wrote: Starting with ath9k: use ieee80211_tx_status_noskb where possible [d94a461d7a7df68991fb9663531173f60ef89c68] the driver uses rcu_read_lock() && rcu_read_unlock() yet on returning early in ath_tx_edma_tasklet

Re: [PATCH] ath9k: unlock rcu read when returning early

2016-12-13 Thread Felix Fietkau
On 2016-12-12 19:50, Tobias Klausmann wrote: > Starting with ath9k: use ieee80211_tx_status_noskb where possible > [d94a461d7a7df68991fb9663531173f60ef89c68] the driver uses rcu_read_lock() && > rcu_read_unlock() yet on returning early in ath_tx_edma_tasklet() the unlock > is > missing leading to

Re: [PATCH] ath9k: unlock rcu read when returning early

2016-12-13 Thread Kalle Valo
Tobias Klausmann writes: > Starting with ath9k: use ieee80211_tx_status_noskb where possible > [d94a461d7a7df68991fb9663531173f60ef89c68] The correct format to reference a commit in the commit log is: Starting with commit d94a461d7a7d ("ath9k: use ieee80211_tx_status_noskb where possible") the.

[PATCH] ath9k: unlock rcu read when returning early

2016-12-12 Thread Tobias Klausmann
Starting with ath9k: use ieee80211_tx_status_noskb where possible [d94a461d7a7df68991fb9663531173f60ef89c68] the driver uses rcu_read_lock() && rcu_read_unlock() yet on returning early in ath_tx_edma_tasklet() the unlock is missing leading to stalls and suspicious RCU usage: =