Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-27 Thread Kalle Valo
Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_ATH9K is built-in but LED support is in a loadable > module, both ath9k drivers fails to link: > > x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function > `ath_deinit_leds': > gpio.c:(.text+0x36): undefined reference to

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-27 Thread Johannes Berg
On Wed, 2021-01-27 at 12:35 +0200, Kalle Valo wrote: > Arnd Bergmann writes: > > > On Mon, Jan 25, 2021 at 4:04 PM Krzysztof Kozlowski wrote: > > > On Mon, 25 Jan 2021 at 15:38, Arnd Bergmann wrote: > > > > On Mon, Jan 25, 2021 at 2:27 PM Krzysztof Kozlowski > > > > wrote: > > > > > > I mean

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-27 Thread Kalle Valo
Arnd Bergmann writes: > On Mon, Jan 25, 2021 at 4:04 PM Krzysztof Kozlowski wrote: >> On Mon, 25 Jan 2021 at 15:38, Arnd Bergmann wrote: >> > On Mon, Jan 25, 2021 at 2:27 PM Krzysztof Kozlowski >> > wrote: >> >> I meant that having MAC80211_LEDS selected causes the ath9k driver to >> toggle o

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-26 Thread Krzysztof Kozlowski
On Mon, 25 Jan 2021 at 15:38, Arnd Bergmann wrote: > > On Mon, Jan 25, 2021 at 2:27 PM Krzysztof Kozlowski wrote: > > On Mon, 25 Jan 2021 at 14:09, Arnd Bergmann wrote: > > > On Mon, Jan 25, 2021 at 12:40 PM Krzysztof Kozlowski > > > wrote: > > > > On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-25 Thread Arnd Bergmann
On Mon, Jan 25, 2021 at 2:27 PM Krzysztof Kozlowski wrote: > On Mon, 25 Jan 2021 at 14:09, Arnd Bergmann wrote: > > On Mon, Jan 25, 2021 at 12:40 PM Krzysztof Kozlowski > > wrote: > > > On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann wrote: > > > But we do not want to have this dependency (selecti

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-25 Thread Krzysztof Kozlowski
On Mon, 25 Jan 2021 at 14:09, Arnd Bergmann wrote: > > On Mon, Jan 25, 2021 at 12:40 PM Krzysztof Kozlowski wrote: > > On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann wrote: > > > > > > From: Arnd Bergmann > > > > > > When CONFIG_ATH9K is built-in but LED support is in a loadable > > > module, both

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-25 Thread Arnd Bergmann
On Mon, Jan 25, 2021 at 12:40 PM Krzysztof Kozlowski wrote: > On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > When CONFIG_ATH9K is built-in but LED support is in a loadable > > module, both ath9k drivers fails to link: > > > > x86_64-linux-ld: drivers/net/w

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-25 Thread Krzysztof Kozlowski
On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann wrote: > > From: Arnd Bergmann > > When CONFIG_ATH9K is built-in but LED support is in a loadable > module, both ath9k drivers fails to link: > > x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function > `ath_deinit_leds': > gpio.c:(.text+0

[PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-25 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_ATH9K is built-in but LED support is in a loadable module, both ath9k drivers fails to link: x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function `ath_deinit_leds': gpio.c:(.text+0x36): undefined reference to `led_classdev_unregister' x86_64-linux-

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-25 Thread Arnd Bergmann
On Mon, Jan 25, 2021 at 4:04 PM Krzysztof Kozlowski wrote: > On Mon, 25 Jan 2021 at 15:38, Arnd Bergmann wrote: > > On Mon, Jan 25, 2021 at 2:27 PM Krzysztof Kozlowski wrote: > > I meant that having MAC80211_LEDS selected causes the ath9k driver to > toggle on/off the WiFi LED. Every second, reg