Re: [PATCH] arm_pmu: fix compiler warning in arm_pmu_device_probe

2018-08-02 Thread Chris Packham
On 02/08/18 23:05, Will Deacon wrote: > On Thu, Aug 02, 2018 at 09:45:26AM +1200, Chris Packham wrote: >> GCC warns >> >>arm_pmu_platform.c:234:5: error: 'err' may be used uninitialized in this >> function [-Werror=maybe-uninitialized] >> >> This is because we rely on the for_each_cpu loop in

Re: [PATCH] arm_pmu: fix compiler warning in arm_pmu_device_probe

2018-08-02 Thread Will Deacon
On Thu, Aug 02, 2018 at 09:45:26AM +1200, Chris Packham wrote: > GCC warns > > arm_pmu_platform.c:234:5: error: 'err' may be used uninitialized in this > function [-Werror=maybe-uninitialized] > > This is because we rely on the for_each_cpu loop in armpmu_request_irqs > to initialise err. The

Re: [PATCH] arm_pmu: fix compiler warning in arm_pmu_device_probe

2018-08-02 Thread Robin Murphy
Hi Chris, On 01/08/18 22:45, Chris Packham wrote: GCC warns arm_pmu_platform.c:234:5: error: 'err' may be used uninitialized in this function [-Werror=maybe-uninitialized] This is because we rely on the for_each_cpu loop in armpmu_request_irqs to initialise err. The warning is a little bog

[PATCH] arm_pmu: fix compiler warning in arm_pmu_device_probe

2018-08-01 Thread Chris Packham
GCC warns arm_pmu_platform.c:234:5: error: 'err' may be used uninitialized in this function [-Werror=maybe-uninitialized] This is because we rely on the for_each_cpu loop in armpmu_request_irqs to initialise err. The warning is a little bogus because we know if there were 0 CPUs this code woul