Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-28 Thread Nick Desaulniers
On Thu, May 28, 2020 at 12:20 AM Will Deacon wrote: > > Yes, I know that :) Right, I forgot; you wrote the 64b one. :) On Thu, May 28, 2020 at 2:41 AM Catalin Marinas wrote: > > On Thu, May 28, 2020 at 09:05:08AM +0100, Peter Smith wrote: > > I suggest using Arm if you need a frame pointer, and

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-28 Thread Catalin Marinas
On Thu, May 28, 2020 at 09:05:08AM +0100, Peter Smith wrote: > I suggest using Arm if you need a frame pointer, and disable the > frame pointer if you want/need to use Thumb. My understanding is that > runtime unwinding using the frame pointer in Thumb is already difficult > due to Arm and Thumb fu

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-28 Thread Peter Smith
pick...@linaro.org; Arnd > Bergmann; Peter Smith > Subject: Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm > > On Wed, May 27, 2020 at 1:14 PM Nick Desaulniers > wrote: > > > > On Wed, May 27, 2020 at 12:28 PM Robin Murphy wrote: > > > > > &

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-28 Thread Will Deacon
On Wed, May 27, 2020 at 11:17:33AM -0700, Nick Desaulniers wrote: > On Wed, May 27, 2020 at 11:08 AM Will Deacon wrote: > > > > On Wed, May 27, 2020 at 10:55:24AM -0700, Nick Desaulniers wrote: > > > On Wed, May 27, 2020 at 6:45 AM Robin Murphy wrote: > > > > > > > > On 2020-05-26 18:31, Nick Des

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-27 Thread Nick Desaulniers
On Wed, May 27, 2020 at 1:31 PM Nick Desaulniers wrote: > > On Wed, May 27, 2020 at 1:14 PM Nick Desaulniers > wrote: > > > > On Wed, May 27, 2020 at 12:28 PM Robin Murphy wrote: > > > > > > On 2020-05-27 18:55, Nick Desaulniers wrote: > > > > On Wed, May 27, 2020 at 6:45 AM Robin Murphy > > >

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-27 Thread Nick Desaulniers
On Wed, May 27, 2020 at 1:14 PM Nick Desaulniers wrote: > > On Wed, May 27, 2020 at 12:28 PM Robin Murphy wrote: > > > > On 2020-05-27 18:55, Nick Desaulniers wrote: > > > On Wed, May 27, 2020 at 6:45 AM Robin Murphy wrote: > > >> > > >> On 2020-05-26 18:31, Nick Desaulniers wrote: > > >>> Custo

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-27 Thread Nick Desaulniers
On Wed, May 27, 2020 at 12:28 PM Robin Murphy wrote: > > On 2020-05-27 18:55, Nick Desaulniers wrote: > > On Wed, May 27, 2020 at 6:45 AM Robin Murphy wrote: > >> > >> On 2020-05-26 18:31, Nick Desaulniers wrote: > >>> Custom toolchains that modify the default target to -mthumb cannot > >>> compi

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-27 Thread Robin Murphy
On 2020-05-27 20:28, Robin Murphy wrote: On 2020-05-27 18:55, Nick Desaulniers wrote: On Wed, May 27, 2020 at 6:45 AM Robin Murphy wrote: On 2020-05-26 18:31, Nick Desaulniers wrote: Custom toolchains that modify the default target to -mthumb cannot compile the arm64 compat vdso32, as arch/a

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-27 Thread Robin Murphy
On 2020-05-27 18:55, Nick Desaulniers wrote: On Wed, May 27, 2020 at 6:45 AM Robin Murphy wrote: On 2020-05-26 18:31, Nick Desaulniers wrote: Custom toolchains that modify the default target to -mthumb cannot compile the arm64 compat vdso32, as arch/arm64/include/asm/vdso/compat_gettimeofday.

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-27 Thread Nick Desaulniers
On Wed, May 27, 2020 at 11:08 AM Will Deacon wrote: > > On Wed, May 27, 2020 at 10:55:24AM -0700, Nick Desaulniers wrote: > > On Wed, May 27, 2020 at 6:45 AM Robin Murphy wrote: > > > > > > On 2020-05-26 18:31, Nick Desaulniers wrote: > > > > Custom toolchains that modify the default target to -m

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-27 Thread Will Deacon
On Wed, May 27, 2020 at 10:55:24AM -0700, Nick Desaulniers wrote: > On Wed, May 27, 2020 at 6:45 AM Robin Murphy wrote: > > > > On 2020-05-26 18:31, Nick Desaulniers wrote: > > > Custom toolchains that modify the default target to -mthumb cannot > > > compile the arm64 compat vdso32, as > > > arch

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-27 Thread Nick Desaulniers
On Wed, May 27, 2020 at 6:53 AM Dave Martin wrote: > > On Tue, May 26, 2020 at 09:45:05PM +0100, Will Deacon wrote: > > On Tue, 26 May 2020 10:31:14 -0700, Nick Desaulniers wrote: > > > Custom toolchains that modify the default target to -mthumb cannot > > It's probably too late to water this down

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-27 Thread Nick Desaulniers
On Wed, May 27, 2020 at 6:45 AM Robin Murphy wrote: > > On 2020-05-26 18:31, Nick Desaulniers wrote: > > Custom toolchains that modify the default target to -mthumb cannot > > compile the arm64 compat vdso32, as > > arch/arm64/include/asm/vdso/compat_gettimeofday.h > > contains assembly that's inv

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-27 Thread Dave Martin
On Tue, May 26, 2020 at 09:45:05PM +0100, Will Deacon wrote: > On Tue, 26 May 2020 10:31:14 -0700, Nick Desaulniers wrote: > > Custom toolchains that modify the default target to -mthumb cannot It's probably too late to water this down, but it's unfortunate to have this comment in the upstream com

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-27 Thread Robin Murphy
On 2020-05-26 18:31, Nick Desaulniers wrote: Custom toolchains that modify the default target to -mthumb cannot compile the arm64 compat vdso32, as arch/arm64/include/asm/vdso/compat_gettimeofday.h contains assembly that's invalid in -mthumb. Force the use of -marm, always. FWIW, this seems su

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-26 Thread Will Deacon
On Tue, 26 May 2020 10:31:14 -0700, Nick Desaulniers wrote: > Custom toolchains that modify the default target to -mthumb cannot > compile the arm64 compat vdso32, as > arch/arm64/include/asm/vdso/compat_gettimeofday.h > contains assembly that's invalid in -mthumb. Force the use of -marm, > always

Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-26 Thread Stephen Boyd
Quoting Nick Desaulniers (2020-05-26 10:31:14) > Custom toolchains that modify the default target to -mthumb cannot > compile the arm64 compat vdso32, as > arch/arm64/include/asm/vdso/compat_gettimeofday.h > contains assembly that's invalid in -mthumb. Force the use of -marm, > always. > > Link:

[PATCH] arm64: vdso32: force vdso32 to be compiled as -marm

2020-05-26 Thread Nick Desaulniers
Custom toolchains that modify the default target to -mthumb cannot compile the arm64 compat vdso32, as arch/arm64/include/asm/vdso/compat_gettimeofday.h contains assembly that's invalid in -mthumb. Force the use of -marm, always. Link: https://bugs.chromium.org/p/chromium/issues/detail?id=1084372