Re: [PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-21 Thread Chen Gang
On 05/21/2013 09:15 PM, Catalin Marinas wrote: > On Tue, May 21, 2013 at 11:13:08AM +0100, Chen Gang wrote: >> > On 05/21/2013 05:03 PM, Will Deacon wrote: >>> > > On Tue, May 21, 2013 at 08:51:39AM +0100, Chen Gang wrote: > >> For me, I still recommend add 'ARM64' in the long list of >

Re: [PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-21 Thread Catalin Marinas
On Tue, May 21, 2013 at 11:13:08AM +0100, Chen Gang wrote: > On 05/21/2013 05:03 PM, Will Deacon wrote: > > On Tue, May 21, 2013 at 08:51:39AM +0100, Chen Gang wrote: > >> For me, I still recommend add 'ARM64' in the long list of architectures > >> for 'VGA_CONSOLE', I have 3 reasons, please check:

Re: [PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-21 Thread Chen Gang
On 05/21/2013 07:07 PM, Geert Uytterhoeven wrote: > On Tue, May 21, 2013 at 9:51 AM, Chen Gang wrote: >> > On 05/21/2013 02:57 PM, Geert Uytterhoeven wrote: >>> >> On Tue, May 21, 2013 at 5:15 AM, Chen Gang wrote: >>> >> I think it would be better if we added a something like >>> >>>

Re: [PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-21 Thread Geert Uytterhoeven
On Tue, May 21, 2013 at 9:51 AM, Chen Gang wrote: > On 05/21/2013 02:57 PM, Geert Uytterhoeven wrote: >> On Tue, May 21, 2013 at 5:15 AM, Chen Gang wrote: >> I think it would be better if we added a something like >> CONFIG_HAVE_VGA_CONSOLE, which VGA_CONSOLE can then depend on. >

Re: [PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-21 Thread Chen Gang
On 05/21/2013 05:03 PM, Will Deacon wrote: > On Tue, May 21, 2013 at 08:51:39AM +0100, Chen Gang wrote: >> On 05/21/2013 02:57 PM, Geert Uytterhoeven wrote: >>> On Tue, May 21, 2013 at 5:15 AM, Chen Gang wrote: >>> I think it would be better if we added a something like >>> CONFIG_HAVE_VGA

Re: [PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-21 Thread Will Deacon
On Tue, May 21, 2013 at 08:51:39AM +0100, Chen Gang wrote: > On 05/21/2013 02:57 PM, Geert Uytterhoeven wrote: > > On Tue, May 21, 2013 at 5:15 AM, Chen Gang wrote: > >>> >> I think it would be better if we added a something like > >>> >> CONFIG_HAVE_VGA_CONSOLE, which VGA_CONSOLE can then depend

Re: [PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-21 Thread Chen Gang
On 05/21/2013 02:57 PM, Geert Uytterhoeven wrote: > On Tue, May 21, 2013 at 5:15 AM, Chen Gang wrote: >>> >> I think it would be better if we added a something like >>> >> CONFIG_HAVE_VGA_CONSOLE, which VGA_CONSOLE can then depend on. >>> >> Architectures >>> >> like x86 can then select the forme

Re: [PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-20 Thread Geert Uytterhoeven
On Tue, May 21, 2013 at 5:15 AM, Chen Gang wrote: >> I think it would be better if we added a something like >> CONFIG_HAVE_VGA_CONSOLE, which VGA_CONSOLE can then depend on. Architectures >> like x86 can then select the former, and we can remove the long list of >> architectures from the current

Re: [PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-20 Thread Chen Gang
On 05/20/2013 05:10 PM, Will Deacon wrote: > Hi Chen, > > On Mon, May 20, 2013 at 06:42:46AM +0100, Chen Gang wrote: >> >> Add the extern variable 'screen_info' according to arm32 has done. >> >> The related error: >> drivers/video/console/vgacon.c:1305: undefined reference to `screen_info' >> >

Re: [PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-20 Thread Will Deacon
Hi Chen, On Mon, May 20, 2013 at 06:42:46AM +0100, Chen Gang wrote: > > Add the extern variable 'screen_info' according to arm32 has done. > > The related error: > drivers/video/console/vgacon.c:1305: undefined reference to `screen_info' > > > Signed-off-by: Chen Gang > --- > arch/arm64/ke

[PATCH] arm64: kernel: need extern variable 'screen_info' for related driver using.

2013-05-19 Thread Chen Gang
Add the extern variable 'screen_info' according to arm32 has done. The related error: drivers/video/console/vgacon.c:1305: undefined reference to `screen_info' Signed-off-by: Chen Gang --- arch/arm64/kernel/setup.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff