Re: [PATCH] arm64: fix address fault during mapping fdt region

2016-08-01 Thread Mark Rutland
On Mon, Aug 01, 2016 at 09:17:09PM +0800, zijun_hu wrote: > On 08/01/2016 07:24 PM, Mark Rutland wrote: > > On Mon, Aug 01, 2016 at 06:59:50PM +0800, zijun_hu wrote: > >> 2，it is more portable; we only need to call fdt_check_header() and don't > >> care about fdt header filed layout; moreover,fdt m

Re: [PATCH] arm64: fix address fault during mapping fdt region

2016-08-01 Thread zijun_hu
On 08/01/2016 07:24 PM, Mark Rutland wrote: > On Mon, Aug 01, 2016 at 06:59:50PM +0800, zijun_hu wrote: >> On 08/01/2016 05:50 PM, Ard Biesheuvel wrote: >>> On 1 August 2016 at 11:42, zijun_hu wrote: >>> Couldn't we simply do this instead? >> this solution maybe better, my reason as follows： >> >>

Re: [PATCH] arm64: fix address fault during mapping fdt region

2016-08-01 Thread Greg KH
On Mon, Aug 01, 2016 at 05:42:19PM +0800, zijun_hu wrote: > >From 07b9216ec3494515e7a6c41e0333eb8782427db3 Mon Sep 17 00:00:00 2001 > From: zijun_hu > Date: Mon, 1 Aug 2016 17:04:59 +0800 > Subject: [PATCH] arm64: fix address fault during mapping fdt region > > fdt_check_he

Re: [PATCH] arm64: fix address fault during mapping fdt region

2016-08-01 Thread Mark Rutland
On Mon, Aug 01, 2016 at 06:59:50PM +0800, zijun_hu wrote: > On 08/01/2016 05:50 PM, Ard Biesheuvel wrote: > > On 1 August 2016 at 11:42, zijun_hu wrote: > > Couldn't we simply do this instead? > this solution maybe better, my reason as follows： > > 1，it can achieve our original purpose, namely, c

Re: [PATCH] arm64: fix address fault during mapping fdt region

2016-08-01 Thread Mark Rutland
On Mon, Aug 01, 2016 at 11:50:39AM +0200, Ard Biesheuvel wrote: > On 1 August 2016 at 11:42, zijun_hu wrote: > > From 07b9216ec3494515e7a6c41e0333eb8782427db3 Mon Sep 17 00:00:00 2001 > > From: zijun_hu > > Date: Mon, 1 Aug 2016 17:04:59 +0800 > > Subject: [PATCH] arm6

Re: [PATCH] arm64: fix address fault during mapping fdt region

2016-08-01 Thread zijun_hu
On 08/01/2016 05:50 PM, Ard Biesheuvel wrote: > On 1 August 2016 at 11:42, zijun_hu wrote: >> From 07b9216ec3494515e7a6c41e0333eb8782427db3 Mon Sep 17 00:00:00 2001 >> From: zijun_hu >> Date: Mon, 1 Aug 2016 17:04:59 +0800 >> Subject: [PATCH] arm64: fix address faul

Re: [PATCH] arm64: fix address fault during mapping fdt region

2016-08-01 Thread Ard Biesheuvel
On 1 August 2016 at 11:42, zijun_hu wrote: > From 07b9216ec3494515e7a6c41e0333eb8782427db3 Mon Sep 17 00:00:00 2001 > From: zijun_hu > Date: Mon, 1 Aug 2016 17:04:59 +0800 > Subject: [PATCH] arm64: fix address fault during mapping fdt region > > fdt_check_header() accesses o

[PATCH] arm64: fix address fault during mapping fdt region

2016-08-01 Thread zijun_hu
>From 07b9216ec3494515e7a6c41e0333eb8782427db3 Mon Sep 17 00:00:00 2001 From: zijun_hu Date: Mon, 1 Aug 2016 17:04:59 +0800 Subject: [PATCH] arm64: fix address fault during mapping fdt region fdt_check_header() accesses other fileds of fdt header but the first 8 bytes such as version;