Re: [PATCH] arm64: export tishift functions to modules

2018-04-26 Thread Will Deacon
Hi Jason, On Tue, Apr 24, 2018 at 05:56:39PM +0200, Jason A. Donenfeld wrote: > On Tue, Apr 24, 2018 at 5:40 PM, Will Deacon wrote: > > On Tue, Apr 24, 2018 at 03:43:04PM +0200, Jason A. Donenfeld wrote: > >> On Tue, Apr 24, 2018 at 3:34 PM, Will Deacon wrote: > >> > I've not run into any build

Re: [PATCH] arm64: export tishift functions to modules

2018-04-24 Thread Jason A. Donenfeld
On Tue, Apr 24, 2018 at 5:40 PM, Will Deacon wrote: > On Tue, Apr 24, 2018 at 03:43:04PM +0200, Jason A. Donenfeld wrote: >> On Tue, Apr 24, 2018 at 3:34 PM, Will Deacon wrote: >> > I've not run into any build issues here -- is this specifically with some >> > out-of-tree module? >> >> I received

Re: [PATCH] arm64: export tishift functions to modules

2018-04-24 Thread Will Deacon
On Tue, Apr 24, 2018 at 03:43:04PM +0200, Jason A. Donenfeld wrote: > On Tue, Apr 24, 2018 at 3:34 PM, Will Deacon wrote: > > I've not run into any build issues here -- is this specifically with some > > out-of-tree module? > > I received a bug report email about this. I'm not sure which specific

Re: [PATCH] arm64: export tishift functions to modules

2018-04-24 Thread Jason A. Donenfeld
On Tue, Apr 24, 2018 at 3:34 PM, Will Deacon wrote: > I've not run into any build issues here -- is this specifically with some > out-of-tree module? I received a bug report email about this. I'm not sure which specific module, and I assumed from the email that it was actually a result of in-tree

Re: [PATCH] arm64: export tishift functions to modules

2018-04-24 Thread Will Deacon
Hi Jason, On Sun, Apr 15, 2018 at 06:04:16PM +0200, Jason A. Donenfeld wrote: > Otherwise modules that use these arithmetic operations will fail to > link. We accomplish this with EXPORT_SYMBOL in the .S file, but because > of symbol versioning, we actually need to have a declaration of these > to

[PATCH] arm64: export tishift functions to modules

2018-04-15 Thread Jason A. Donenfeld
Otherwise modules that use these arithmetic operations will fail to link. We accomplish this with EXPORT_SYMBOL in the .S file, but because of symbol versioning, we actually need to have a declaration of these too in C. So, we introduce asm-prototypes.h, which is the same file name and technique us