Re: [PATCH] arm64: PCI: Validate the node before setting node id for root bus

2020-11-12 Thread Lorenzo Pieralisi
[+Jonathan] On Mon, Nov 09, 2020 at 08:27:09PM +0800, Baolin Wang wrote: [...] > I did some investigation for this issue. I am sorry I made some > misleading description in the commit message. The issue is, when we > want to disable the NUMA from firmware, we usually just remove the SRAT > table

Re: [PATCH] arm64: PCI: Validate the node before setting node id for root bus

2020-11-09 Thread Baolin Wang
Hi Lorenzo, On Tue, Sep 29, 2020 at 11:41:29PM +0800, Baolin Wang wrote: Hi, 锟斤拷 2020/9/28 23:23, Lorenzo Pieralisi 写锟斤拷: On Mon, Sep 28, 2020 at 10:49:57PM +0800, Baolin Wang wrote: On Mon, Sep 28, 2020 at 03:00:55PM +0100, Will Deacon wrote: [+ Lorenzo] On Tue, Sep 22, 2020 at 06:33:24

Re: [PATCH] arm64: PCI: Validate the node before setting node id for root bus

2020-10-03 Thread Baolin Wang
On Tue, Sep 29, 2020 at 11:41:29PM +0800, Baolin Wang wrote: Hi, 锟斤拷 2020/9/28 23:23, Lorenzo Pieralisi 写锟斤拷: On Mon, Sep 28, 2020 at 10:49:57PM +0800, Baolin Wang wrote: On Mon, Sep 28, 2020 at 03:00:55PM +0100, Will Deacon wrote: [+ Lorenzo] On Tue, Sep 22, 2020 at 06:33:24PM +0800, Bao

Re: [PATCH] arm64: PCI: Validate the node before setting node id for root bus

2020-10-01 Thread Lorenzo Pieralisi
On Tue, Sep 29, 2020 at 11:41:29PM +0800, Baolin Wang wrote: > Hi, > > 锟斤拷 2020/9/28 23:23, Lorenzo Pieralisi 写锟斤拷: > > On Mon, Sep 28, 2020 at 10:49:57PM +0800, Baolin Wang wrote: > > > On Mon, Sep 28, 2020 at 03:00:55PM +0100, Will Deacon wrote: > > > > [+ Lorenzo] > > > > > > > > On Tue, Sep 2

Re: [PATCH] arm64: PCI: Validate the node before setting node id for root bus

2020-09-29 Thread Baolin Wang
Hi, 在 2020/9/28 23:23, Lorenzo Pieralisi 写道: On Mon, Sep 28, 2020 at 10:49:57PM +0800, Baolin Wang wrote: On Mon, Sep 28, 2020 at 03:00:55PM +0100, Will Deacon wrote: [+ Lorenzo] On Tue, Sep 22, 2020 at 06:33:24PM +0800, Baolin Wang wrote: If the BIOS disabled the NUMA configuration, but did

Re: [PATCH] arm64: PCI: Validate the node before setting node id for root bus

2020-09-28 Thread Lorenzo Pieralisi
On Mon, Sep 28, 2020 at 10:49:57PM +0800, Baolin Wang wrote: > On Mon, Sep 28, 2020 at 03:00:55PM +0100, Will Deacon wrote: > > [+ Lorenzo] > > > > On Tue, Sep 22, 2020 at 06:33:24PM +0800, Baolin Wang wrote: > > > If the BIOS disabled the NUMA configuration, but did not change the > > > proximity

Re: [PATCH] arm64: PCI: Validate the node before setting node id for root bus

2020-09-28 Thread Baolin Wang
On Mon, Sep 28, 2020 at 03:00:55PM +0100, Will Deacon wrote: > [+ Lorenzo] > > On Tue, Sep 22, 2020 at 06:33:24PM +0800, Baolin Wang wrote: > > If the BIOS disabled the NUMA configuration, but did not change the > > proximity domain description in the SRAT table, so the PCI root bus > > device may

Re: [PATCH] arm64: PCI: Validate the node before setting node id for root bus

2020-09-28 Thread Will Deacon
[+ Lorenzo] On Tue, Sep 22, 2020 at 06:33:24PM +0800, Baolin Wang wrote: > If the BIOS disabled the NUMA configuration, but did not change the > proximity domain description in the SRAT table, so the PCI root bus > device may get a incorrect node id by acpi_get_node(). How "incorrect" are we talk

[PATCH] arm64: PCI: Validate the node before setting node id for root bus

2020-09-22 Thread Baolin Wang
If the BIOS disabled the NUMA configuration, but did not change the proximity domain description in the SRAT table, so the PCI root bus device may get a incorrect node id by acpi_get_node(). Thus better to add a numa node validation before setting numa node for the PCI root bus, like pci_acpi_root