RE: [PATCH] arm64: Explicitly mark 64-bit constant as unsigned long

2018-11-19 Thread David Laight
From: Olof Johansson > Sent: 17 November 2018 01:55 ... > -#if (SCTLR_EL2_SET ^ SCTLR_EL2_CLEAR) != 0x > +#if (SCTLR_EL2_SET ^ SCTLR_EL2_CLEAR) != 0xul > #error "Inconsistent SCTLR_EL2 set/clear bits" > #endif Wouldn't this be clearer if written: #if SCT

Re: [PATCH] arm64: Explicitly mark 64-bit constant as unsigned long

2018-11-16 Thread Olof Johansson
On Fri, Nov 16, 2018 at 6:27 PM Will Deacon wrote: > > Hi Olof, > > On Fri, Nov 16, 2018 at 05:54:56PM -0800, Olof Johansson wrote: > > Makes sparse happy. Before: > > > > arch/arm64/include/asm/sysreg.h:471:42: warning: constant > > 0x is so big it is unsigned long > > arch/arm64

Re: [PATCH] arm64: Explicitly mark 64-bit constant as unsigned long

2018-11-16 Thread Will Deacon
Hi Olof, On Fri, Nov 16, 2018 at 05:54:56PM -0800, Olof Johansson wrote: > Makes sparse happy. Before: > > arch/arm64/include/asm/sysreg.h:471:42: warning: constant 0x > is so big it is unsigned long > arch/arm64/include/asm/sysreg.h:512:42: warning: constant 0x

[PATCH] arm64: Explicitly mark 64-bit constant as unsigned long

2018-11-16 Thread Olof Johansson
Makes sparse happy. Before: arch/arm64/include/asm/sysreg.h:471:42: warning: constant 0x is so big it is unsigned long arch/arm64/include/asm/sysreg.h:512:42: warning: constant 0x is so big it is unsigned long Signed-off-by: Olof Johansson --- arch/arm64/includ