Re: nvram and generic_nvram modules are problematic, was Re: [PATCH] arch: m68k: mac: misc.c: Remove some unused functions

2015-02-02 Thread Finn Thain
On Sun, 1 Feb 2015, Russell King - ARM Linux wrote: > On Sun, Feb 01, 2015 at 02:39:42PM +1100, Finn Thain wrote: > > I find the ARM support in drivers/char/nvram to be surprising, not to > > say questionable. The /proc/driver/nvram implementation, given > > defined(__arm__), decodes the NVRAM

Re: nvram and generic_nvram modules are problematic, was Re: [PATCH] arch: m68k: mac: misc.c: Remove some unused functions

2015-02-02 Thread Finn Thain
On Sun, 1 Feb 2015, Geert Uytterhoeven wrote: > On Sun, Feb 1, 2015 at 4:39 AM, Finn Thain wrote: > > On Sun, 4 Jan 2015, Geert Uytterhoeven wrote: > > > On Sun, Jan 4, 2015 at 8:21 AM, Finn Thain wrote: > > > > On Thu, 1 Jan 2015, Rickard Strandqvist wrote: > > > > > Removes some functions that

Re: nvram and generic_nvram modules are problematic, was Re: [PATCH] arch: m68k: mac: misc.c: Remove some unused functions

2015-02-01 Thread Geert Uytterhoeven
On Sun, Feb 1, 2015 at 4:39 AM, Finn Thain wrote: > On Sun, 4 Jan 2015, Geert Uytterhoeven wrote: > >> On Sun, Jan 4, 2015 at 8:21 AM, Finn Thain >> wrote: >> > On Thu, 1 Jan 2015, Rickard Strandqvist wrote: >> > > Removes some functions that are not used anywhere: >> > > mac_pram_write() mac_pr

Re: nvram and generic_nvram modules are problematic, was Re: [PATCH] arch: m68k: mac: misc.c: Remove some unused functions

2015-02-01 Thread Russell King - ARM Linux
On Sun, Feb 01, 2015 at 02:39:42PM +1100, Finn Thain wrote: > I find the ARM support in drivers/char/nvram to be surprising, not to say > questionable. The /proc/driver/nvram implementation, given > defined(__arm__), decodes the NVRAM contents in exactly the same format as > when defined(__i386_

nvram and generic_nvram modules are problematic, was Re: [PATCH] arch: m68k: mac: misc.c: Remove some unused functions

2015-01-31 Thread Finn Thain
On Sun, 4 Jan 2015, Geert Uytterhoeven wrote: > On Sun, Jan 4, 2015 at 8:21 AM, Finn Thain wrote: > > On Thu, 1 Jan 2015, Rickard Strandqvist wrote: > > > Removes some functions that are not used anywhere: > > > mac_pram_write() mac_pram_read() > > > > ... I'd rather not remove all of this code.

Re: [PATCH] arch: m68k: mac: misc.c: Remove some unused functions

2015-01-04 Thread Geert Uytterhoeven
On Sun, Jan 4, 2015 at 8:21 AM, Finn Thain wrote: > On Thu, 1 Jan 2015, Rickard Strandqvist wrote: >> Removes some functions that are not used anywhere: >> mac_pram_write() mac_pram_read() > > If you remove those functions, you'd then find that all of the called > functions become unused: > > maci

Re: [PATCH] arch: m68k: mac: misc.c: Remove some unused functions

2015-01-03 Thread Finn Thain
On Thu, 1 Jan 2015, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > mac_pram_write() mac_pram_read() > If you remove those functions, you'd then find that all of the called functions become unused: maciisi_read_pram maciisi_write_pram pmu_read_pram pmu_write_

[PATCH] arch: m68k: mac: misc.c: Remove some unused functions

2015-01-01 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: mac_pram_write() mac_pram_read() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/m68k/mac/misc.c | 46 -- 1 file change