Re: [PATCH] arch/x86: Remove second call to topology_update_package_map()

2016-10-12 Thread Prarit Bhargava
On 10/12/2016 06:06 PM, Tim Chen wrote: > On Wed, 2016-10-12 at 16:54 -0400, Prarit Bhargava wrote: >> >> On 10/12/2016 03:51 PM, Tim Chen wrote: >>> >>> On Wed, 2016-10-12 at 11:06 -0400, Prarit Bhargava wrote: On 10/12/2016 10:36 AM, Prarit Bhargava wrote: > > > This

Re: [PATCH] arch/x86: Remove second call to topology_update_package_map()

2016-10-12 Thread Tim Chen
On Wed, 2016-10-12 at 16:54 -0400, Prarit Bhargava wrote: > > On 10/12/2016 03:51 PM, Tim Chen wrote: > > > > On Wed, 2016-10-12 at 11:06 -0400, Prarit Bhargava wrote: > > > > > > > > > On 10/12/2016 10:36 AM, Prarit Bhargava wrote: > > > > > > > > > > > > This was noticed during the investig

Re: [PATCH] arch/x86: Remove second call to topology_update_package_map()

2016-10-12 Thread Prarit Bhargava
On 10/12/2016 03:51 PM, Tim Chen wrote: > On Wed, 2016-10-12 at 11:06 -0400, Prarit Bhargava wrote: >> >> On 10/12/2016 10:36 AM, Prarit Bhargava wrote: >>> >>> This was noticed during the investigation of >>> >>> http://git.kernel.org/tip/2a51fe083eba7f99cbda72f5ef90cdf2f4df882c >>> >>> A note f

Re: [PATCH] arch/x86: Remove second call to topology_update_package_map()

2016-10-12 Thread Tim Chen
On Wed, 2016-10-12 at 11:06 -0400, Prarit Bhargava wrote: > > On 10/12/2016 10:36 AM, Prarit Bhargava wrote: > > > > This was noticed during the investigation of > > > > http://git.kernel.org/tip/2a51fe083eba7f99cbda72f5ef90cdf2f4df882c > > > > A note for reviewers on the cleanup in smp_init_pa

Re: [PATCH] arch/x86: Remove second call to topology_update_package_map()

2016-10-12 Thread Prarit Bhargava
On 10/12/2016 10:36 AM, Prarit Bhargava wrote: > This was noticed during the investigation of > > http://git.kernel.org/tip/2a51fe083eba7f99cbda72f5ef90cdf2f4df882c > > A note for reviewers on the cleanup in smp_init_package_map(): The > per_cpu variable x86_bios_cpu_apicid is initialized to BA

[PATCH] arch/x86: Remove second call to topology_update_package_map()

2016-10-12 Thread Prarit Bhargava
This was noticed during the investigation of http://git.kernel.org/tip/2a51fe083eba7f99cbda72f5ef90cdf2f4df882c A note for reviewers on the cleanup in smp_init_package_map(): The per_cpu variable x86_bios_cpu_apicid is initialized to BAD_APICID, and the bitmaps are set to false by default so the