Thank you Eric. I have updated the bugzilla ticket with new patch,
will wait for test results from ticket author.
--
Andrey Utkin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ke
On Mon, 2014-07-07 at 13:02 +0300, Andrey Utkin wrote:
> 2014-07-07 12:26 GMT+03:00 Eric Dumazet :
> > Reading again this code, I think all you need is to remove the 2 buggy
> > lines.
> >
> > No need for setup destructors.
>
> Reviewing the code again, i find you're right and adding a destructor
2014-07-07 12:26 GMT+03:00 Eric Dumazet :
> Reading again this code, I think all you need is to remove the 2 buggy
> lines.
>
> No need for setup destructors.
Reviewing the code again, i find you're right and adding a destructor
in that place is stupid, and just not setting skb->sk would make bug
On Mon, 2014-07-07 at 10:57 +0200, Eric Dumazet wrote:
> On Mon, 2014-07-07 at 11:03 +0300, Andrey Utkin wrote:
> > 2014-07-07 0:42 GMT+03:00 Eric Dumazet :
> > >> /* Queue packet (standard) */
> > >> + sock_hold(sock);
> > >> + skb->destructor = atalk_skb_destructor;
> > >> skb
On Mon, 2014-07-07 at 11:03 +0300, Andrey Utkin wrote:
> 2014-07-07 0:42 GMT+03:00 Eric Dumazet :
> >> /* Queue packet (standard) */
> >> + sock_hold(sock);
> >> + skb->destructor = atalk_skb_destructor;
> >> skb->sk = sock;
> >
> > This part is not needed : sock_queue_rcv_skb()
2014-07-07 0:42 GMT+03:00 Eric Dumazet :
>> /* Queue packet (standard) */
>> + sock_hold(sock);
>> + skb->destructor = atalk_skb_destructor;
>> skb->sk = sock;
>
> This part is not needed : sock_queue_rcv_skb() already does the right
> thing : It calls skb_set_owner_r(skb, sk);
On Sun, 2014-07-06 at 14:56 +0300, Andrey Utkin wrote:
> The sock ref counting is off so there is a kernel panic when you run
> `atalkd`. See https://bugzilla.kernel.org/show_bug.cgi?id=79441
> This fix is similar to 0ae89beb283a ('can: add destructor for self
> generated skbs')
> should
> Report
The sock ref counting is off so there is a kernel panic when you run
`atalkd`. See https://bugzilla.kernel.org/show_bug.cgi?id=79441
This fix is similar to 0ae89beb283a ('can: add destructor for self
generated skbs')
Reported-by: Ed Martin
Signed-off-by: Andrey Utkin
---
net/appletalk/ddp.c |
On Sat, Jul 05, 2014 at 07:28:14AM +0300, Andrey Utkin wrote:
> See https://bugzilla.kernel.org/show_bug.cgi?id=79441
> ---8<---
> Made changes similar to 0ae89beb283a0db5980d1d4781c7d7be2f2810d6
>
Thanks for fixing this bug but the patch description is just a URL and a
git hash. Say something l
See https://bugzilla.kernel.org/show_bug.cgi?id=79441
---8<---
Made changes similar to 0ae89beb283a0db5980d1d4781c7d7be2f2810d6
Reported-by: Ed Martin
Signed-off-by: Andrey Utkin
---
net/appletalk/ddp.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/net/appletalk/ddp.c b/net/apple
10 matches
Mail list logo
