Re: [PATCH] apparmor: fix error check

2021-02-07 Thread John Johansen
On 10/4/20 7:24 AM, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis reports this representative problem: > > label.c:1463:16: warning: Assigned value is garbage or undefined > label->hname = name; > ^ > > In aa_update_label_name(), this the pro

Re: [PATCH] apparmor: fix error check

2020-12-21 Thread Nick Desaulniers
On Sun, Oct 4, 2020 at 7:24 AM wrote: > > From: Tom Rix > > clang static analysis reports this representative problem: > > label.c:1463:16: warning: Assigned value is garbage or undefined > label->hname = name; > ^ Right, so if aa_label_acntsxprint() fails, it w

[PATCH] apparmor: fix error check

2020-10-04 Thread trix
From: Tom Rix clang static analysis reports this representative problem: label.c:1463:16: warning: Assigned value is garbage or undefined label->hname = name; ^ In aa_update_label_name(), this the problem block of code if (aa_label_acntsxprint(&name, .