Re: [PATCH] alarmtimer: Fix bug where relative alarm timers were treated as absolute

2014-07-08 Thread John Stultz
On Tue, Jul 8, 2014 at 8:42 AM, Richard Cochran wrote: > On Mon, Jul 07, 2014 at 02:06:11PM -0700, John Stultz wrote: >> @@ -597,8 +602,16 @@ static int alarm_timer_set(struct k_itimer *timr, int >> flags, >> >> /* start the timer */ >> timr->it.alarm.interval = timespec_to_ktime(new_

Re: [PATCH] alarmtimer: Fix bug where relative alarm timers were treated as absolute

2014-07-07 Thread Richard Cochran
On Mon, Jul 07, 2014 at 02:06:11PM -0700, John Stultz wrote: > @@ -597,8 +602,16 @@ static int alarm_timer_set(struct k_itimer *timr, int > flags, > > /* start the timer */ > timr->it.alarm.interval = timespec_to_ktime(new_setting->it_interval); > - alarm_start(&timr->it.alarm.al

[PATCH] alarmtimer: Fix bug where relative alarm timers were treated as absolute

2014-07-07 Thread John Stultz
Sharvil noticed with the posix timer_settime interface, using the CLOCK_REALTIME_ALARM or CLOCK_BOOTTIME_ALARM clockid, if the users tried to specify a relative time timer, it would incorrectly be treated as absolute regardless of the state of the flags argument. This patch corrects this, properly