Re: [PATCH] aio: use wait_for_completion_io() when waiting for completion of io

2020-08-27 Thread Jan Kara
Hi! On Thu 27-08-20 16:28:37, 田 wrote: > I understood what you said before:) Good :) > Totally agree with you, that we should fix the common path to make it to > account IO wait time. Currently kernel only has io_wait_event(), which > does not support timeout, maybe we need develop new interf

Re: [PATCH] aio: use wait_for_completion_io() when waiting for completion of io

2020-08-27 Thread Jan Kara
Hello! On Wed 26-08-20 23:44:11, 田 wrote: > thanks for your kindly reply, > the normal wait path read_events()->wait_event_interruptible_hrtimeout(), > which will call schedule(), it does not account IO wait time. Not sure if there isn't some misunderstanding so I'll repeat what I've said: Yes, a

Re: [PATCH] aio: use wait_for_completion_io() when waiting for completion of io

2020-08-26 Thread Jan Kara
On Wed 05-08-20 09:35:51, Xianting Tian wrote: > When waiting for the completion of io, we need account iowait time. As > wait_for_completion() calls schedule_timeout(), which doesn't account > iowait time. While wait_for_completion_io() calls io_schedule_timeout(), > which will account iowait time

[PATCH] aio: use wait_for_completion_io() when waiting for completion of io

2020-08-05 Thread Xianting Tian
When waiting for the completion of io, we need account iowait time. As wait_for_completion() calls schedule_timeout(), which doesn't account iowait time. While wait_for_completion_io() calls io_schedule_timeout(), which will account iowait time. So using wait_for_completion_io() instead of wait_fo