Re: [RESEND PATCH] af_packet: don't pass empty blocks for PACKET_V3

2015-02-24 Thread David Miller
From: Alexander Drozdov Date: Tue, 24 Feb 2015 08:18:28 +0300 > Before da413eec729d ("packet: Fixed TPACKET V3 to signal poll when block is > closed rather than every packet") poll listening for an af_packet socket was > not signaled if there was no packets to process. After the patch poll is > s

[RESEND PATCH] af_packet: don't pass empty blocks for PACKET_V3

2015-02-23 Thread Alexander Drozdov
Before da413eec729d ("packet: Fixed TPACKET V3 to signal poll when block is closed rather than every packet") poll listening for an af_packet socket was not signaled if there was no packets to process. After the patch poll is signaled evety time when block retire timer expires. That happens because

Re: [PATCH] af_packet: don't pass empty blocks for PACKET_V3

2015-02-06 Thread Willem de Bruijn
On Thu, Feb 5, 2015 at 10:54 PM, Alexander Drozdov wrote: > On 05.02.2015 23:01:38 +0300 Willem de Bruijn wrote: >> >> On Wed, Feb 4, 2015 at 9:58 PM, Alexander Drozdov >> wrote: >>> >>> Don't close an empty block on timeout. Its meaningless to >>> pass it to the user. Moreover, passing empty blo

Re: [PATCH] af_packet: don't pass empty blocks for PACKET_V3

2015-02-05 Thread Alexander Drozdov
On 05.02.2015 23:01:38 +0300 Willem de Bruijn wrote: On Wed, Feb 4, 2015 at 9:58 PM, Alexander Drozdov wrote: Don't close an empty block on timeout. Its meaningless to pass it to the user. Moreover, passing empty blocks wastes CPU & buffer space increasing probability of packets dropping on sma

Re: [PATCH] af_packet: don't pass empty blocks for PACKET_V3

2015-02-05 Thread Alexander Drozdov
On 06.02.2015 00:16:30 +0300 Guy Harris wrote: On Feb 5, 2015, at 12:01 PM, Willem de Bruijn wrote: On Wed, Feb 4, 2015 at 9:58 PM, Alexander Drozdov wrote: Don't close an empty block on timeout. Its meaningless to pass it to the user. Moreover, passing empty blocks wastes CPU & buffer spac

Re: [PATCH] af_packet: don't pass empty blocks for PACKET_V3

2015-02-05 Thread Guy Harris
On Feb 5, 2015, at 12:01 PM, Willem de Bruijn wrote: > On Wed, Feb 4, 2015 at 9:58 PM, Alexander Drozdov > wrote: >> Don't close an empty block on timeout. Its meaningless to >> pass it to the user. Moreover, passing empty blocks wastes >> CPU & buffer space increasing probability of packets >

Re: [PATCH] af_packet: don't pass empty blocks for PACKET_V3

2015-02-05 Thread Willem de Bruijn
On Wed, Feb 4, 2015 at 9:58 PM, Alexander Drozdov wrote: > Don't close an empty block on timeout. Its meaningless to > pass it to the user. Moreover, passing empty blocks wastes > CPU & buffer space increasing probability of packets > dropping on small timeouts. > > Side effect of this patch is in

[PATCH] af_packet: don't pass empty blocks for PACKET_V3

2015-02-04 Thread Alexander Drozdov
Don't close an empty block on timeout. Its meaningless to pass it to the user. Moreover, passing empty blocks wastes CPU & buffer space increasing probability of packets dropping on small timeouts. Side effect of this patch is indefinite user-space wait in poll on idle links. But, I believe its be