Re: [PATCH] add_partition silently ignored errors

2007-11-02 Thread Dirk Hohndel
On Fri, Nov 02, 2007 at 03:50:29PM -0400, Bob Copeland wrote: > On 11/2/07, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > > @@ -554,8 +573,11 @@ int rescan_partitions(struct gendisk *disk, struct > > > > block_device *bdev) > > > > if (from + size > get_capacity(disk)) { > > > >

Re: [PATCH] add_partition silently ignored errors

2007-11-02 Thread Bob Copeland
On 11/2/07, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > @@ -554,8 +573,11 @@ int rescan_partitions(struct gendisk *disk, struct > > > block_device *bdev) > > > if (from + size > get_capacity(disk)) { > > > printk(" %s: p%d exceeds device capacity\n", > > >

Re: [PATCH] add_partition silently ignored errors

2007-11-02 Thread Dirk Hohndel
On Fri, Nov 02, 2007 at 02:04:39PM +0100, Jens Axboe wrote: > > > > > > > > > IIRC, Al recently vetoed a similar patch. As far as I'm concerned, > > > > > > with > > > > > > the correct return values, the patch then looks fine to me. > > > > So Al, are you ok with this one? Still haven't seen f

Re: [PATCH] add_partition silently ignored errors

2007-11-02 Thread Jens Axboe
On Tue, Oct 30 2007, Dirk Hohndel wrote: > On Tue, Oct 30, 2007 at 06:31:12PM +0100, Cornelia Huck wrote: > > On Tue, 30 Oct 2007 09:56:08 -0700, > > Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > > > > > IIRC, Al recently vetoed a similar patch. As far as I'm concerned, > > > > > with > > > > > t

Re: [PATCH] add_partition silently ignored errors

2007-10-31 Thread Cornelia Huck
On Tue, 30 Oct 2007 15:56:35 -0700, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > On Tue, Oct 30, 2007 at 06:31:12PM +0100, Cornelia Huck wrote: > > On Tue, 30 Oct 2007 09:56:08 -0700, > > Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > > > > > IIRC, Al recently vetoed a similar patch. As far as I'm co

Re: [PATCH] add_partition silently ignored errors

2007-10-30 Thread Dirk Hohndel
On Tue, Oct 30, 2007 at 06:31:12PM +0100, Cornelia Huck wrote: > On Tue, 30 Oct 2007 09:56:08 -0700, > Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > > > IIRC, Al recently vetoed a similar patch. As far as I'm concerned, with > > > > the correct return values, the patch then looks fine to me. So A

Re: [PATCH] add_partition silently ignored errors

2007-10-30 Thread Cornelia Huck
On Tue, 30 Oct 2007 09:56:08 -0700, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > IIRC, Al recently vetoed a similar patch. As far as I'm concerned, with > > > the correct return values, the patch then looks fine to me. > > > > We need some kind of check concerning the kobject to avoid mysterious

Re: [PATCH] add_partition silently ignored errors

2007-10-30 Thread Dirk Hohndel
On Tue, Oct 30, 2007 at 10:09:34AM +0100, Cornelia Huck wrote: > On Tue, 30 Oct 2007 09:07:42 +0100, > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > > > -void add_partition(struct gendisk *disk, int part, sector_t start, > > > sector_t len, int flags) > > > +int add_partition(struct gendisk *

Re: [PATCH] add_partition silently ignored errors

2007-10-30 Thread Cornelia Huck
On Tue, 30 Oct 2007 09:07:42 +0100, Jens Axboe <[EMAIL PROTECTED]> wrote: > On Mon, Oct 29 2007, Dirk Hohndel wrote: > > diff --git a/block/ioctl.c b/block/ioctl.c > > index 52d6385..bb3933e 100644 > > --- a/block/ioctl.c > > +++ b/block/ioctl.c > > @@ -61,7 +61,10 @@ static int blkpg_ioctl(struct

Re: [PATCH] add_partition silently ignored errors

2007-10-30 Thread Jens Axboe
On Mon, Oct 29 2007, Dirk Hohndel wrote: > diff --git a/block/ioctl.c b/block/ioctl.c > index 52d6385..bb3933e 100644 > --- a/block/ioctl.c > +++ b/block/ioctl.c > @@ -61,7 +61,10 @@ static int blkpg_ioctl(struct block_device *bdev, struct > blkpg_ioctl_arg __user > }

Re: [PATCH] add_partition silently ignored errors

2007-10-29 Thread Cornelia Huck
On Mon, 29 Oct 2007 08:48:49 -0700, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > [PATCH] add_partition silently ignored errors > > Signed-off-by: Dirk Hohndel <[EMAIL PROTECTED]> > > --- > block/ioctl.c |5 - > fs/partitions/check.c | 30

Re: [PATCH] add_partition silently ignored errors

2007-10-29 Thread Dirk Hohndel
gt;part_uevent_suppress) > > + kobject_uevent(&p->kobj, KOBJ_REMOVE); > > + kobject_del(&p->kobj); > > You need a kobject_put() here to drop the reference you obtained in > kobject_init(). done We should be getting close

Re: [PATCH] add_partition silently ignored errors

2007-10-29 Thread Cornelia Huck
On Mon, 29 Oct 2007 07:24:27 -0700, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > @@ -390,20 +390,33 @@ void add_partition(struct gendisk *disk, int part, > sector_t start, sector_t len, > p->kobj.parent = &disk->kobj; > p->kobj.ktype = &ktype_part; > kobject_init(&p->kobj); > -

Re: [PATCH] add_partition silently ignored errors

2007-10-29 Thread Dirk Hohndel
On Mon, Oct 29, 2007 at 02:06:57PM +0100, Cornelia Huck wrote: > On Mon, 29 Oct 2007 05:22:11 -0700, > Dirk Hohndel <[EMAIL PROTECTED]> wrote: > > > > > @@ -390,20 +390,31 @@ void add_partition(struct gendisk *disk, int part, > > sector_t start, sector_t len, > > p->kobj.parent = &disk->kob

Re: [PATCH] add_partition silently ignored errors

2007-10-29 Thread Cornelia Huck
On Mon, 29 Oct 2007 05:22:11 -0700, Dirk Hohndel <[EMAIL PROTECTED]> wrote: > @@ -390,20 +390,31 @@ void add_partition(struct gendisk *disk, int part, > sector_t start, sector_t len, > p->kobj.parent = &disk->kobj; > p->kobj.ktype = &ktype_part; > kobject_init(&p->kobj); > -

[PATCH] add_partition silently ignored errors

2007-10-29 Thread Dirk Hohndel
Yet another issue where we ignore errors - this needs someone to make sure that I am passing around the right error codes (and am cleaning up correctly) [PATCH] add_partition silently ignored errors Signed-off-by: Dirk Hohndel <[EMAIL PROTECTED]> --- block/ioctl.c |5 +++