Re: [PATCH] acpi-cpufreq.c: fix a memory leak in acpi_cpufreq_cpu_exit

2015-07-07 Thread Pan Xinhui
hi, Viresh thanks for your quick reply :) On 2015年07月07日 16:53, Viresh Kumar wrote: > On 07-07-15, 15:52, Pan Xinhui wrote: >> I have latest codes. >> codes in cpufreq.c are below. >> 1436 down_write(&policy->rwsem); >> 1437 cpumask_clear_cpu(cpu, policy->cpus); >> 1438 >> 1439

Re: [PATCH] acpi-cpufreq.c: fix a memory leak in acpi_cpufreq_cpu_exit

2015-07-07 Thread Viresh Kumar
On 07-07-15, 15:52, Pan Xinhui wrote: > I have latest codes. > codes in cpufreq.c are below. > 1436 down_write(&policy->rwsem); > 1437 cpumask_clear_cpu(cpu, policy->cpus); > 1438 > 1439 if (policy_is_inactive(policy)) { > 1440 if (has_target()) > 1441 strncpy(polic

Re: [PATCH] acpi-cpufreq.c: fix a memory leak in acpi_cpufreq_cpu_exit

2015-07-07 Thread Pan Xinhui
hi, Viresh thanks for your reply. On 2015年07月07日 14:54, Viresh Kumar wrote: > On 06-07-15, 14:30, Pan Xinhui wrote: >> >> policy->cpu in acpi_cpufreq_cpu_init/exit is the same cpu in most cases. >> However during cpu hotplug, >> cpufreq core might nominate a new cpu for policy->cpu. > > W

Re: [PATCH] acpi-cpufreq.c: fix a memory leak in acpi_cpufreq_cpu_exit

2015-07-06 Thread Viresh Kumar
On 06-07-15, 14:30, Pan Xinhui wrote: > > policy->cpu in acpi_cpufreq_cpu_init/exit is the same cpu in most cases. > However during cpu hotplug, > cpufreq core might nominate a new cpu for policy->cpu. Why aren't above lines well aligned? A simple trick to share for vim users: - Select lines you

[PATCH] acpi-cpufreq.c: fix a memory leak in acpi_cpufreq_cpu_exit

2015-07-05 Thread Pan Xinhui
policy->cpu in acpi_cpufreq_cpu_init/exit is the same cpu in most cases. However during cpu hotplug, cpufreq core might nominate a new cpu for policy->cpu. Thar will cause a memory leak in acpi_cpufreq_cpu_exit. To avoid this issue, use field *driver_data* to keep the the pointer of acpi_cpufreq_