Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-07-04 Thread Hoan Tran
On Tue, May 31, 2016 at 12:29 PM, Ashwin Chaugule wrote: > > On 27 May 2016 at 12:41, Hoan Tran wrote: > > Hi Ashwin, > > Hi, > > > > > Yes, I saw kernel crash. > > As cpc_desc_ptr is not NULL, cppc_cpufreq_init() still can pass then > > crash during cppc_get_perf_caps() access CPPC shared memory

Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-06-24 Thread Rafael J. Wysocki
On Friday, June 24, 2016 09:35:32 AM Hoan Tran wrote: > On Tue, May 31, 2016 at 12:29 PM, Ashwin Chaugule > wrote: > > > > On 27 May 2016 at 12:41, Hoan Tran wrote: > > > Hi Ashwin, > > > > Hi, > > > > > > > > Yes, I saw kernel crash. > > > As cpc_desc_ptr is not NULL, cppc_cpufreq_init() still c

Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-06-24 Thread Hoan Tran
On Tue, May 31, 2016 at 12:29 PM, Ashwin Chaugule wrote: > > On 27 May 2016 at 12:41, Hoan Tran wrote: > > Hi Ashwin, > > Hi, > > > > > Yes, I saw kernel crash. > > As cpc_desc_ptr is not NULL, cppc_cpufreq_init() still can pass then > > crash during cppc_get_perf_caps() access CPPC shared memory

Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-05-31 Thread Hoan Tran
Hi Ashwin, On Tue, May 31, 2016 at 12:29 PM, Ashwin Chaugule wrote: > On 27 May 2016 at 12:41, Hoan Tran wrote: >> Hi Ashwin, > > Hi, > >> >> Yes, I saw kernel crash. >> As cpc_desc_ptr is not NULL, cppc_cpufreq_init() still can pass then >> crash during cppc_get_perf_caps() access CPPC shared

Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-05-31 Thread Ashwin Chaugule
On 27 May 2016 at 12:41, Hoan Tran wrote: > Hi Ashwin, Hi, > > Yes, I saw kernel crash. > As cpc_desc_ptr is not NULL, cppc_cpufreq_init() still can pass then > crash during cppc_get_perf_caps() access CPPC shared memory. > > It's not only "PCC channel request fail" can create this issue but > "

Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-05-27 Thread Hoan Tran
Hi Ashwin, Yes, I saw kernel crash. As cpc_desc_ptr is not NULL, cppc_cpufreq_init() still can pass then crash during cppc_get_perf_caps() access CPPC shared memory. It's not only "PCC channel request fail" can create this issue but "acpi_get_psd() fail" also creates it Thanks Hoan On Fri, May

Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-05-27 Thread Ashwin Chaugule
On 25 May 2016 at 15:09, Hoan Tran wrote: > When CPPC fails to request PCC channel, the CPC data is freed > and cpc_desc_ptr points to the invalid data. This change prevents > this issue by moving cpc_desc_ptr assignment after PCC channel > request. > > Signed-off-by: Hoan Tran > --- > drivers/a

[PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-05-25 Thread Hoan Tran
When CPPC fails to request PCC channel, the CPC data is freed and cpc_desc_ptr points to the invalid data. This change prevents this issue by moving cpc_desc_ptr assignment after PCC channel request. Signed-off-by: Hoan Tran --- drivers/acpi/cppc_acpi.c | 6 +++--- 1 file changed, 3 insertions(+