Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-12 Thread Timur Tabi
ok...@codeaurora.org wrote: This is what it was before. > if (acpi_irq_balance || !link->irq.active) { >- /* >-* Select the best IRQ. This is done in reverse to promote >-* the use of IRQs 9, 10, 11, and >15. >-*/ >-

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-12 Thread okaya
> On Thu, Nov 12, 2015 at 5:04 PM, Sinan Kaya wrote: >> On 11/12/2015 4:56 AM, Andy Shevchenko wrote: >>> On Thu, Nov 12, 2015 at 8:14 AM, Sinan Kaya >>> wrote: - if (acpi_irq_balance || !link->irq.active) { + if ((acpi_irq_balance || !link->irq.active) && (irq < ACPI_M

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-12 Thread Andy Shevchenko
On Thu, Nov 12, 2015 at 5:04 PM, Sinan Kaya wrote: > On 11/12/2015 4:56 AM, Andy Shevchenko wrote: >> On Thu, Nov 12, 2015 at 8:14 AM, Sinan Kaya wrote: >>> - if (acpi_irq_balance || !link->irq.active) { >>> + if ((acpi_irq_balance || !link->irq.active) && (irq < >>> ACPI_MAX_IRQS))

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-12 Thread Sinan Kaya
On 11/12/2015 4:56 AM, Andy Shevchenko wrote: > On Thu, Nov 12, 2015 at 8:14 AM, Sinan Kaya wrote: >> The ACPI compiler uses the extended format when used >> interrupt numbers are greater than 256. The PCI link code >> currently only supports simple interrupt format. The IRQ >> numbers are represe

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-12 Thread Andy Shevchenko
On Thu, Nov 12, 2015 at 8:14 AM, Sinan Kaya wrote: > The ACPI compiler uses the extended format when used > interrupt numbers are greater than 256. The PCI link code > currently only supports simple interrupt format. The IRQ > numbers are represented using 32 bits when extended IRQ > syntax. This

[PATCH] acpi: add support for extended IRQ to PCI link

2015-11-11 Thread Sinan Kaya
The ACPI compiler uses the extended format when used interrupt numbers are greater than 256. The PCI link code currently only supports simple interrupt format. The IRQ numbers are represented using 32 bits when extended IRQ syntax. This patch changes the interrupt number type to 32 bits and places

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-09 Thread Sinan Kaya
On 11/8/2015 3:35 PM, Andy Shevchenko wrote: On Sun, Nov 8, 2015 at 6:07 PM, Sinan Kaya wrote: The ACPI compiler uses the extended format when used interrupt numbers are greater than 256. The PCI link code currently only supports simple interrupt format. The IRQ numbers are represented using

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-09 Thread Rafael J. Wysocki
On Sunday, November 08, 2015 06:05:48 PM Timur Tabi wrote: > Sinan Kaya wrote: > >> > > 1020 is the maximum interrupt ID that can be directed to an ARM SPI > > interrupt according to ARM architecture. > > IMHO, that's something that belongs in the patch description. Good point. Thanks, Rafael -

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-09 Thread Sinan Kaya
On 11/9/2015 8:50 AM, Timur Tabi wrote: Sinan Kaya wrote: I'm concerned about this though since you warned. This used to consume 1024 bytes now 4096 bytes. static int acpi_irq_penalty[ACPI_MAX_IRQS] = { PIRQ_PENALTY_ISA_ALWAYS,/* IRQ0 timer */ ... } As long as it's not ever put on

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-09 Thread Timur Tabi
Sinan Kaya wrote: I'm concerned about this though since you warned. This used to consume 1024 bytes now 4096 bytes. static int acpi_irq_penalty[ACPI_MAX_IRQS] = { PIRQ_PENALTY_ISA_ALWAYS,/* IRQ0 timer */ ... } As long as it's not ever put on the stack, it should be fine. -- Sent by

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-09 Thread Jiang Liu
On 2015/11/9 13:45, Sinan Kaya wrote: > > > On 11/9/2015 12:24 AM, Jiang Liu wrote: >>> +u32 possible[ACPI_PCI_LINK_MAX_POSSIBLE]; >>> > u8 initialized:1; >>> > u8 reserved:7; >>> > }; >> Hi Sinan, >> This data structure become some sort of big, any idea to reduce >> memory con

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-08 Thread Sinan Kaya
On 11/9/2015 12:24 AM, Jiang Liu wrote: + u32 possible[ACPI_PCI_LINK_MAX_POSSIBLE]; >u8 initialized:1; >u8 reserved:7; > }; Hi Sinan, This data structure become some sort of big, any idea to reduce memory consumption? Thanks, Gerry Hi Gerry, There are two constants in

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-08 Thread Jiang Liu
On 2015/11/9 0:07, Sinan Kaya wrote: > The ACPI compiler uses the extended format when > used interrupt numbers are greater than 256. > The PCI link code currently only supports simple > interrupt format. The IRQ numbers are represented > using 32 bits when extended IRQ syntax. This patch > changes

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-08 Thread Timur Tabi
Sinan Kaya wrote: 1020 is the maximum interrupt ID that can be directed to an ARM SPI interrupt according to ARM architecture. IMHO, that's something that belongs in the patch description. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-08 Thread Sinan Kaya
On 11/8/2015 11:11 AM, Timur Tabi wrote: Sinan Kaya wrote: -#define ACPI_MAX_IRQS256 +#define ACPI_MAX_IRQS1020 Why 1020? Why not 1024? 1020 is the maximum interrupt ID that can be directed to an ARM SPI interrupt according to ARM architecture. -- Sinan Kaya Qualcomm Tec

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-08 Thread Andy Shevchenko
On Sun, Nov 8, 2015 at 6:07 PM, Sinan Kaya wrote: > The ACPI compiler uses the extended format when > used interrupt numbers are greater than 256. > The PCI link code currently only supports simple > interrupt format. The IRQ numbers are represented > using 32 bits when extended IRQ syntax. This p

Re: [PATCH] acpi: add support for extended IRQ to PCI link

2015-11-08 Thread Timur Tabi
Sinan Kaya wrote: -#define ACPI_MAX_IRQS 256 +#define ACPI_MAX_IRQS 1020 Why 1020? Why not 1024? -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation. -- To un

[PATCH] acpi: add support for extended IRQ to PCI link

2015-11-08 Thread Sinan Kaya
The ACPI compiler uses the extended format when used interrupt numbers are greater than 256. The PCI link code currently only supports simple interrupt format. The IRQ numbers are represented using 32 bits when extended IRQ syntax. This patch changes the interrupt number type to 32 bits and places