Re: [PATCH] Xilinx: hwicap: cleanup

2008-02-25 Thread Jiri Slaby
On 02/25/2008 12:21 AM, Stephen Neuendorffer wrote: @@ -549,8 +556,7 @@ static int hwicap_release(struct inode *inode, struct file *file) int i; int status = 0; - if (down_interruptible(&drvdata->sem)) - return -ERESTARTSYS; + mutex_lock(&drvdata->

RE: [PATCH] Xilinx: hwicap: cleanup

2008-02-24 Thread Stephen Neuendorffer
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Grant Likely > Sent: Saturday, February 23, 2008 10:17 PM > To: Stephen Neuendorffer > Cc: [EMAIL PROTECTED]; git-dev; [EMAIL PROTECTED]; [EMAIL PROTECTED] > Subject: Re: [PATCH] Xilin

Re: [PATCH] Xilinx: hwicap: cleanup

2008-02-23 Thread Grant Likely
Stephen, when you address these comments, please double check the lkml address. It was misspelled when you sent this patch. Cheers, g. On Sat, Feb 23, 2008 at 11:16 PM, Grant Likely <[EMAIL PROTECTED]> wrote: > On Mon, Feb 11, 2008 at 11:24 AM, Stephen Neuendorffer > <[EMAIL PROTECTED]> wrote: