Re: [PATCH] WorkStruct: Fix spi_bitbang.h

2006-12-07 Thread David Brownell
On Thursday 07 December 2006 7:37 am, David Howells wrote: > David Brownell <[EMAIL PROTECTED]> wrote: > > > NAK. Headers don't compile. A driver including this _might_ need to > > include that header; most won't. > > Please be more specific. It compiles for myself and for Ben. I used the > s

Re: [PATCH] WorkStruct: Fix spi_bitbang.h

2006-12-07 Thread Andrew Morton
On Thu, 07 Dec 2006 15:37:35 + David Howells <[EMAIL PROTECTED]> wrote: > David Brownell <[EMAIL PROTECTED]> wrote: > > > NAK. Headers don't compile. A driver including this _might_ need to > > include that header; most won't. > > Please be more specific. It compiles for myself and for Be

Re: [PATCH] WorkStruct: Fix spi_bitbang.h

2006-12-07 Thread David Howells
David Brownell <[EMAIL PROTECTED]> wrote: > NAK. Headers don't compile. A driver including this _might_ need to > include that header; most won't. Please be more specific. It compiles for myself and for Ben. I used the s3c2410_defconfig configuration. It won't compile without it. David - To

Re: [PATCH] WorkStruct: Fix spi_bitbang.h

2006-12-07 Thread David Brownell
On Thursday 07 December 2006 4:44 am, David Howells wrote: > Fix spi_bitbang.h. It need to #include before it can > compile. > > Signed-Off-By: David Howells <[EMAIL PROTECTED]> NAK. Headers don't compile. A driver including this _might_ need to include that header; most won't. > --- > >

[PATCH] WorkStruct: Fix spi_bitbang.h

2006-12-07 Thread David Howells
Fix spi_bitbang.h. It need to #include before it can compile. Signed-Off-By: David Howells <[EMAIL PROTECTED]> --- include/linux/spi/spi_bitbang.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/spi/spi_bitbang.h b/include/linux/spi/spi_bitbang.h index 1