RE: [PATCH] Validate pointer when copying mount namespace.

2015-04-28 Thread Ma, Xindong
> Details, please. How do you reproduce that behaviour? > > I don't like that loop in its current form (it relies upon _not_ encountering > the > same ->mnt_root in the parts of tree we hadn't copied), but your change > doesn't make it any better. Seeing a reproducer would be useful in sorting

Re: [PATCH] Validate pointer when copying mount namespace.

2015-04-28 Thread Al Viro
On Wed, Apr 29, 2015 at 09:56:43AM +0800, Leon Ma wrote: > We encountered following panic. Validate the pointer to avoid this. > @@ -2788,7 +2788,7 @@ struct mnt_namespace *copy_mnt_ns(unsigned long flags, > struct mnt_namespace *ns, > q = next_mnt(q, new); > if (!q) >

[PATCH] Validate pointer when copying mount namespace.

2015-04-28 Thread Leon Ma
We encountered following panic. Validate the pointer to avoid this. [35046.276380] BUG: unable to handle kernel NULL pointer dereference at 0010 [35046.283316] IP: [<8095dc91>] copy_mnt_ns+0x111/0x260 [35046.288225] *pdpt = 1b883001 *pde = [35046.293901] Oops: [#1