Re: [PATCH] Use correct macros in raid code, not raw asm

2007-02-08 Thread H. Peter Anvin
Neil Brown wrote: So does this look right (no, I haven't compiled it yet) No, the whole raid6_*_save_t should be removed. I'll try to have a patch for you later. -hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

Re: [PATCH] Use correct macros in raid code, not raw asm

2007-02-08 Thread Neil Brown
On Thursday February 8, [EMAIL PROTECTED] wrote: > Andi Kleen wrote: > > > > It should use kernel_fpu_begin() imho. If someone wants to test > > it in user space again they can add dummy definitions of that > > to their user space header. > > I hadn't seen this thread until now, when Neil pointe

Re: [PATCH] Use correct macros in raid code, not raw asm

2007-02-08 Thread H. Peter Anvin
Andi Kleen wrote: The code looks like it's designed to be included from userspace for testing; as it compiles without this include (and has no other includes), I chose not to add it. Linus makes a good point, but someone who actually knows the code should, y'know, test it and stuff... It shoul

Re: [PATCH] Use correct macros in raid code, not raw asm

2006-12-29 Thread Andi Kleen
> > The code looks like it's designed to be included from userspace for > testing; as it compiles without this include (and has no other > includes), I chose not to add it. > > Linus makes a good point, but someone who actually knows the code > should, y'know, test it and stuff... It should use

Re: [PATCH] Use correct macros in raid code, not raw asm

2006-12-28 Thread Rusty Russell
On Thu, 2006-12-28 at 15:56 -0800, Andrew Morton wrote: > On Fri, 29 Dec 2006 10:34:21 +1100 > Rusty Russell <[EMAIL PROTECTED]> wrote: > > > This make sure it's paravirtualized correctly when CONFIG_PARAVIRT=y. > > > > Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> > > > > diff -r 4ff04862239

Re: [PATCH] Use correct macros in raid code, not raw asm

2006-12-28 Thread Andrew Morton
On Fri, 29 Dec 2006 10:34:21 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote: > This make sure it's paravirtualized correctly when CONFIG_PARAVIRT=y. > > Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> > > diff -r 4ff048622391 drivers/md/raid6x86.h > --- a/drivers/md/raid6x86.h Thu Dec 28 16:52

Re: [PATCH] Use correct macros in raid code, not raw asm

2006-12-28 Thread Linus Torvalds
On Fri, 29 Dec 2006, Rusty Russell wrote: > > This make sure it's paravirtualized correctly when CONFIG_PARAVIRT=y. Why doesn't this code use "kernel_fpu_begin()" and "kernel_fpu_end()"? The raid6 code is crap, and slower. It does "fsave/frstor" or movaps or other crud, and the thing is, it sh

[PATCH] Use correct macros in raid code, not raw asm

2006-12-28 Thread Rusty Russell
This make sure it's paravirtualized correctly when CONFIG_PARAVIRT=y. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 4ff048622391 drivers/md/raid6x86.h --- a/drivers/md/raid6x86.h Thu Dec 28 16:52:54 2006 +1100 +++ b/drivers/md/raid6x86.h Fri Dec 29 10:09:38 2006 +1100 @@ -75,13