Re: [RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

2015-11-05 Thread Arnd Bergmann
On Thursday 05 November 2015 08:37:39 Greg Kroah-Hartman wrote: > On Thu, Nov 05, 2015 at 05:18:41PM +0100, Arnd Bergmann wrote: > > On Thursday 29 October 2015 22:44:31 Tina Ruchandani wrote: > > > struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code > > > currently uses 'struct time

Re: [RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

2015-11-05 Thread Greg Kroah-Hartman
On Thu, Nov 05, 2015 at 05:18:41PM +0100, Arnd Bergmann wrote: > On Thursday 29 October 2015 22:44:31 Tina Ruchandani wrote: > > struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code > > currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr, > > which has a 32-bit se

Re: [RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

2015-11-05 Thread Arnd Bergmann
On Thursday 29 October 2015 22:44:31 Tina Ruchandani wrote: > struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code > currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr, > which has a 32-bit seconds field and will overflow in year 2038 and beyond. > This patch rep

[RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

2015-10-29 Thread Tina Ruchandani
struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr, which has a 32-bit seconds field and will overflow in year 2038 and beyond. This patch replaces 'struct timeval' with 'struct timespec64' which is y2038 safe.

Re: [PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

2015-05-05 Thread Alan Stern
On Mon, 4 May 2015, Tina Ruchandani wrote: > > but the timestamp will also overflow. So what is the point? > > > > The 32-bit timestamp obtained using do_gettimeofday() will overflow in > year 2038. However, with 64-bit timestamps, we get practically > infinite time. mon_bin_hdr already has suppo

Re: [PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

2015-05-04 Thread Tina Ruchandani
> but the timestamp will also overflow. So what is the point? > The 32-bit timestamp obtained using do_gettimeofday() will overflow in year 2038. However, with 64-bit timestamps, we get practically infinite time. mon_bin_hdr already has support for a 64-bit seconds timestamp. This patch changes ho

Re: [PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

2015-05-04 Thread Oliver Neukum
On Tue, 2015-05-05 at 11:50 +0530, Tina Ruchandani wrote: > struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code > currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr, > which has a 32-bit seconds field and will overflow in year 2038 and beyond. > This patch rep

[PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

2015-05-04 Thread Tina Ruchandani
struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr, which has a 32-bit seconds field and will overflow in year 2038 and beyond. This patch replaces 'struct timeval' with 'struct timespec64' which is y2038 sa