Re: [PATCH] TTY: memory leakage in tty_buffer_find()

2013-06-27 Thread Peter Hurley
On 06/26/2013 10:37 PM, channing wrote: On Wed, 2013-06-26 at 08:43 -0400, Peter Hurley wrote: On 06/26/2013 04:51 AM, channing wrote: In tty_buffer_find(), it scans all tty buffers in free buffer queue, if it finds matched one, tty->buf.free will point to matched one's next buffer, so tty buf

Re: [PATCH] TTY: memory leakage in tty_buffer_find()

2013-06-26 Thread channing
On Wed, 2013-06-26 at 08:43 -0400, Peter Hurley wrote: > On 06/26/2013 04:51 AM, channing wrote: > > > > In tty_buffer_find(), it scans all tty buffers in > > free buffer queue, if it finds matched one, > > tty->buf.free will point to matched one's next buffer, > > so tty buffers that ahead of matc

Re: [PATCH] TTY: memory leakage in tty_buffer_find()

2013-06-26 Thread Peter Hurley
On 06/26/2013 04:51 AM, channing wrote: In tty_buffer_find(), it scans all tty buffers in free buffer queue, if it finds matched one, tty->buf.free will point to matched one's next buffer, so tty buffers that ahead of matched one are removed from free queue, they will never be used but they are

Re: [PATCH] TTY: memory leakage in tty_buffer_find()

2013-06-26 Thread Jiri Slaby
On 06/26/2013 10:55 AM, Jiri Slaby wrote: > On 06/26/2013 10:51 AM, channing wrote: >> >> In tty_buffer_find(), it scans all tty buffers in >> free buffer queue, if it finds matched one, >> tty->buf.free will point to matched one's next buffer, > > Oh, how is that true? tbh is moved with every ite

Re: [PATCH] TTY: memory leakage in tty_buffer_find()

2013-06-26 Thread Jiri Slaby
On 06/26/2013 10:51 AM, channing wrote: > > In tty_buffer_find(), it scans all tty buffers in > free buffer queue, if it finds matched one, > tty->buf.free will point to matched one's next buffer, Oh, how is that true? tbh is moved with every iteration, right? Then: *tbh = t->next; 't' is what

[PATCH] TTY: memory leakage in tty_buffer_find()

2013-06-26 Thread channing
In tty_buffer_find(), it scans all tty buffers in free buffer queue, if it finds matched one, tty->buf.free will point to matched one's next buffer, so tty buffers that ahead of matched one are removed from free queue, they will never be used but they are not released, then memory leak happen. Th