Re: [PATCH] Support tablet mode switch for Dell laptops

2018-01-22 Thread Marco Martin
On Mon, Jan 22, 2018 at 12:59 PM, Marco Martin wrote: > On Fri, Jan 19, 2018 at 6:29 PM, Dmitry Torokhov > wrote: >>> We discussed a little more on the bug he filed with attached DSDT. I think >>> that in >>> sparse keymap he can use KE_VSW for the entries and sparse keymap can >>> handle. >>

Re: [PATCH] Support tablet mode switch for Dell laptops

2018-01-22 Thread Marco Martin
On Fri, Jan 19, 2018 at 6:29 PM, Dmitry Torokhov wrote: >> We discussed a little more on the bug he filed with attached DSDT. I think >> that in >> sparse keymap he can use KE_VSW for the entries and sparse keymap can handle. > > No it should be KE_SW I believe, as the "keycode" encodes the stat

Re: [PATCH] Support tablet mode switch for Dell laptops

2018-01-19 Thread Dmitry Torokhov
10:01 AM > > To: Dmitry Torokhov > > Cc: linux-kernel@vger.kernel.org; mj...@srcf.ucam.org; dvh...@infradead.org; > > a...@infradead.org; bhus...@gmail.com; platform-driver-...@vger.kernel.org; > > Marco Martin > > Subject: Re: [PATCH] Support tablet mode switch for D

RE: [PATCH] Support tablet mode switch for Dell laptops

2018-01-19 Thread Mario.Limonciello
srcf.ucam.org; dvh...@infradead.org; > a...@infradead.org; bhus...@gmail.com; platform-driver-...@vger.kernel.org; > Marco Martin > Subject: Re: [PATCH] Support tablet mode switch for Dell laptops > > On Thursday 18 January 2018 16:44:08 Pali Rohár wrote: > > On Thursday 18 January 2018

Re: [PATCH] Support tablet mode switch for Dell laptops

2018-01-19 Thread Pali Rohár
On Thursday 18 January 2018 16:44:08 Pali Rohár wrote: > On Thursday 18 January 2018 14:59:50 Marco Martin wrote: > > - if (!sparse_keymap_report_event(priv->input_dev, event, 1, true)) > > + if (event == 0xCC) { > > + input_report_switch(priv->input_dev, SW_TABLET_MODE, 1); > > +

Re: [PATCH] Support tablet mode switch for Dell laptops

2018-01-18 Thread Marco Martin
On Thu, Jan 18, 2018 at 4:23 PM, wrote: > AFAIK we don't have a public specification for the ACPI interface > that intel-vbtn uses, it's all reverse engineered. > > I think the appropriate thing to do would be open a kernel Bugzilla for your > issue and attach: > 1) kernel log without your patch

Re: [PATCH] Support tablet mode switch for Dell laptops

2018-01-18 Thread Pali Rohár
On Thursday 18 January 2018 14:59:50 Marco Martin wrote: > - if (!sparse_keymap_report_event(priv->input_dev, event, 1, true)) > + if (event == 0xCC) { > + input_report_switch(priv->input_dev, SW_TABLET_MODE, 1); > + input_sync(priv->input_dev); > + } else if (ev

RE: [PATCH] Support tablet mode switch for Dell laptops

2018-01-18 Thread Mario.Limonciello
ist ; Matthew Garrett > ; Pali Rohár ; Darren Hart > ; Andy Shevchenko ; > bhus...@gmail.com; Platform Driver > Subject: Re: [PATCH] Support tablet mode switch for Dell laptops > > On Thu, Jan 18, 2018 at 3:59 PM, Marco Martin wrote: > > Dell laptops send events to in

Re: [PATCH] Support tablet mode switch for Dell laptops

2018-01-18 Thread Andy Shevchenko
On Thu, Jan 18, 2018 at 3:59 PM, Marco Martin wrote: > Dell laptops send events to intel-vbtn.c > 0xCC when the laptop enters in tablet mode and > 0xCD when the laptop goes out of it > > This has been confirmed working on a Dell Inspiron 13-7352 > and an Inspiron 13-7000 > > I'm not sure intel-vbt

[PATCH] Support tablet mode switch for Dell laptops

2018-01-18 Thread Marco Martin
Dell laptops send events to intel-vbtn.c 0xCC when the laptop enters in tablet mode and 0xCD when the laptop goes out of it This has been confirmed working on a Dell Inspiron 13-7352 and an Inspiron 13-7000 I'm not sure intel-vbtn is the right place for it, as it should be dell-specific, but this