Re: Re : Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-22 Thread Minchan Kim
On Mon, Dec 23, 2013 at 12:03:39PM +0900, Chanho Min wrote: > > > > read_pages > > for(page_idx ...) { > > if (!add_to_page_cache_lru)) { <-- 1) > > mapping->a_ops->readpage(filp, page) > > squashfs_readpage > > for (i ...) { 2) Here, 31 pages are inserted into pa

Re: [PATCH] Squashfs: add asynchronous read support

2013-12-22 Thread Phillip Lougher
On 16/12/13 05:30, Chanho Min wrote: This patch removes synchronous wait for the up-to-date of buffer in the file system level. Instead all operations after submit_bh are moved into the End-of-IO handler and its associated workeque. It decompresses/copies data into pages and unlock them asynchron

Re : Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-22 Thread Chanho Min
> read_pages > for(page_idx ...) { > if (!add_to_page_cache_lru)) { <-- 1) > mapping->a_ops->readpage(filp, page) > squashfs_readpage > for (i ...) { 2) Here, 31 pages are inserted into page cache > grab_cahe_page_nowait <--/ > add_to

Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-22 Thread Minchan Kim
On Sat, Dec 21, 2013 at 11:05:51AM +0900, Chanho Min wrote: > > > Please don't break thread. > > You should reply to my mail instead of your original post. > Sorry, It seems to be my mailer issue. I'm trying to fix it. > > > It's a result which isn't what I want to know. > > What I wnat to know i

Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-20 Thread Chanho Min
> Please don't break thread. > You should reply to my mail instead of your original post. Sorry, It seems to be my mailer issue. I'm trying to fix it. > It's a result which isn't what I want to know. > What I wnat to know is why upper layer issues more I/O per second. > For example, you read 32K

Re: Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-17 Thread Minchan Kim
Hello, Please don't break thread. You should reply to my mail instead of your original post. On Wed, Dec 18, 2013 at 01:29:37PM +0900, Chanho Min wrote: > > > I did test it on x86 with USB stick and ARM with eMMC on my Nexus 4. > > In experiment, I couldn't see much gain like you both system and

Re : Re: [PATCH] Squashfs: add asynchronous read support

2013-12-17 Thread Chanho Min
> I did test it on x86 with USB stick and ARM with eMMC on my Nexus 4. > In experiment, I couldn't see much gain like you both system and even it > was regressed at bs=32k test, maybe workqueue allocation/schedule of work > per I/O. > Your test is rather special or what I am missing? Can you speci

Re: [PATCH] Squashfs: add asynchronous read support

2013-12-16 Thread Minchan Kim
Hello Chanho, On Mon, Dec 16, 2013 at 02:30:26PM +0900, Chanho Min wrote: > This patch removes synchronous wait for the up-to-date of buffer in the > file system level. Instead all operations after submit_bh are moved into > the End-of-IO handler and its associated workeque. It decompresses/copies

[PATCH] Squashfs: add asynchronous read support

2013-12-15 Thread Chanho Min
This patch removes synchronous wait for the up-to-date of buffer in the file system level. Instead all operations after submit_bh are moved into the End-of-IO handler and its associated workeque. It decompresses/copies data into pages and unlock them asynchronously. This patch enhances the perform