Re: [PATCH] Smackv9: Use a stateful parser for parsing Smack rules

2007-11-02 Thread Ahmed S. Darwish
On 11/1/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Nov 1 2007 17:54, Ahmed S. Darwish wrote: > >+ > >+static inline int isblank(char c) > >+{ > >+ return (c == ' ' || c == '\t'); > >+} > > Use isspace(). > isspace accepts newlines and carriage-returns too which is not accepted betwe

Re: [PATCH] Smackv9: Use a stateful parser for parsing Smack rules

2007-11-01 Thread Jan Engelhardt
On Nov 1 2007 17:54, Ahmed S. Darwish wrote: >+ >+static inline int isblank(char c) >+{ >+ return (c == ' ' || c == '\t'); >+} Use isspace(). >+ for (i = 0; i < count && data[i]; i ++) >... >+ subjectstr[(*label_len) ++] = data[i]; i++ w/o space - To unsubscribe f

[PATCH] Smackv9: Use a stateful parser for parsing Smack rules

2007-11-01 Thread Ahmed S. Darwish
Hi Casey/Al/all, A patch that utilizes Al Viro's concerns on previous smack parser and solves pevious parser bugs discovered by Ahmed Darwish. By now, no problem will occur if given smack rules are fragmented over multiple write() calls. CC: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Ahmed S. Dar