Re: [PATCH] SUNRPC: return negative value in case rpcbind client creation error

2012-07-31 Thread Stanislav Kinsbursky
31.07.2012 03:12, Myklebust, Trond пишет: On Fri, 2012-07-20 at 15:57 +0400, Stanislav Kinsbursky wrote: Without this patch kernel will panic on LockD start, because lockd_up() checks lockd_up_net() result for negative value. >From my pow it's better to return negative value from rpcbind routine

Re: [PATCH] SUNRPC: return negative value in case rpcbind client creation error

2012-07-30 Thread bfie...@fieldses.org
On Mon, Jul 30, 2012 at 11:12:05PM +, Myklebust, Trond wrote: > On Fri, 2012-07-20 at 15:57 +0400, Stanislav Kinsbursky wrote: > > Without this patch kernel will panic on LockD start, because lockd_up() > > checks > > lockd_up_net() result for negative value. > > >From my pow it's better to re

Re: [PATCH] SUNRPC: return negative value in case rpcbind client creation error

2012-07-30 Thread Myklebust, Trond
On Fri, 2012-07-20 at 15:57 +0400, Stanislav Kinsbursky wrote: > Without this patch kernel will panic on LockD start, because lockd_up() checks > lockd_up_net() result for negative value. > >From my pow it's better to return negative value from rpcbind routines > >instead > of replacing all such c

[PATCH] SUNRPC: return negative value in case rpcbind client creation error

2012-07-20 Thread Stanislav Kinsbursky
Without this patch kernel will panic on LockD start, because lockd_up() checks lockd_up_net() result for negative value. >From my pow it's better to return negative value from rpcbind routines instead of replacing all such checks like in lockd_up(). Signed-off-by: Stanislav Kinsbursky --- net/su