Re: [PATCH] SLAB : Use num_possible_cpus() in enable_cpucache()

2007-03-21 Thread Christoph Lameter
On Wed, 21 Mar 2007, Eric Dumazet wrote: > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Acked-by: Christoph Lameter <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

Re: [PATCH] SLAB : Use num_possible_cpus() in enable_cpucache()

2007-03-21 Thread Pekka Enberg
On 3/21/07, Eric Dumazet <[EMAIL PROTECTED]> wrote: As most shiped linux kernels are now compiled with CONFIG_SMP, there is no way a preprocessor #if can detect if the machine is UP or SMP. Better to use num_possible_cpus(). Looks good to me. Acked-by: Pekka Enberg <[EMAIL PROTECTED]> - To uns

[PATCH] SLAB : Use num_possible_cpus() in enable_cpucache()

2007-03-20 Thread Eric Dumazet
The existing comment in mm/slab.c is *perfect*, so I reproduce it : /* * CPU bound tasks (e.g. network routing) can exhibit cpu bound * allocation behaviour: Most allocs on one cpu, most free operations * on another cpu. For these cases, an efficient object pass